PG19: handle property graph dependency object classes - #8733
Merged
ibrahim halatci (ihalatci) merged 1 commit intoAug 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pg19-support #8733 +/- ##
================================================
- Coverage 88.80% 88.75% -0.06%
================================================
Files 288 289 +1
Lines 64416 65006 +590
Branches 8100 8191 +91
================================================
+ Hits 57206 57693 +487
- Misses 4873 4952 +79
- Partials 2337 2361 +24 🚀 New features to boost your workflow:
|
ibrahim halatci (ihalatci)
force-pushed
the
ihalatci-fix-pg19-property-graph
branch
from
August 10, 2026 03:54
b73e5f6 to
323d1ae
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ibrahim halatci (ihalatci)
force-pushed
the
ihalatci-fix-pg19-property-graph
branch
from
August 10, 2026 04:14
323d1ae to
7718954
Compare
Onur Tirtir (onurctirtir)
approved these changes
Aug 10, 2026
ibrahim halatci (ihalatci)
merged commit Aug 10, 2026
be8f0a2
into
pg19-support
182 of 195 checks passed
ibrahim halatci (ihalatci)
deleted the
ihalatci-fix-pg19-property-graph
branch
August 10, 2026 08:18
24 of 29 tasks
Onur Tirtir (onurctirtir)
pushed a commit
that referenced
this pull request
Sep 25, 2026
DESCRIPTION: Align Citus compatibility code with PostgreSQL 19 beta4 ## Summary - use the green PostgreSQL 19 beta4 development images from citusdata/the-process#250 (`-dev-64e776f`) - update PG19 CI and nightly cassert matrices from `19beta3` to `19beta4` - remove property-graph compatibility reverted upstream between `REL_19_BETA3` and `REL_19_BETA4` - preserve the remaining PostgreSQL 19 compatibility work already merged on `main` ## Upstream delta Replayed the applicable parts of PostgreSQL's `REL_19_BETA3..REL_19_BETA4` `src/backend/utils/adt/ruleutils.c` delta onto Citus's curated `ruleutils_19.c`: removed the five `pg_propgraph_*` includes, graph-pattern deparse helpers, and `RTE_GRAPH_TABLE` branches while preserving Citus-specific hooks and shard-aware deparsing. The Beta 4 build exposed two additional removed upstream symbols. This PR removes only their corresponding compatibility branches: - `OBJECT_PROPGRAPH` in `pg_get_object_address_17_18.c` - `RTE_GRAPH_TABLE` in `citus_nodefuncs.c` ## Compatibility audit Removes #8733. Retains #8622, #8624, #8741, #8784, #8785, and #8795 because their underlying PostgreSQL 19 behavior remains in beta4. Pending PG19 feature PRs are unchanged. Closes #8597. ## Validation - built PostgreSQL `REL_19_BETA4` from source under native Ubuntu-22.04 WSL - `PG_CONFIG=<beta4-prefix>/bin/pg_config ./configure` - `make -j"$(nproc)"` - `make install -j"$(nproc)"` - `src/test/regress/citus_tests/run_test.py pg19` — all 7 tests passed - `citus_indent --quiet --check` — passed - `git diff --check` — passed in Windows and WSL checkouts - repository-wide removed-symbol search — no stale matches `make check-style` reaches the existing Python isort gate and reports `src/test/regress/citus_tests/test/test_run_test.py`, which is unchanged from `origin/main`. The C formatting check for this diff passes. Full Build & Test CI is required. --------- Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
privilegesregression pass; original object-class 6470/6473 errors no longer reproduceFixes #8729
Fixes #8729.
Upstream provenance
The property-graph catalogs and relation OIDs 6470/6473 predate PG19 Beta1. Beta2-range PostgreSQL commit
9d8cdcbe0c8abegan recording graph-label/property dependencies, which exposed those pre-existingObjectAddress.classIdvalues to Citus and triggered the stale compatibility mapper. Thus the omission was latent in Beta1 and directly exposed by Beta2 dependency behavior.