Add citus-merge-loop and citus-check-style-reindent SKILLs - #8876
Open
Onur Tirtir (onurctirtir) wants to merge 6 commits into
Open
Onur Tirtir (onurctirtir) wants to merge 6 commits into
Onur Tirtir (onurctirtir) wants to merge 6 commits into
Conversation
Also shorten the description of .github\skills\citus-backport\SKILL.md.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8876 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 290 290
Lines 65149 65149
Branches 8225 8225
=======================================
+ Hits 57835 57836 +1
Misses 4938 4938
+ Partials 2376 2375 -1 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
ibrahim halatci (ihalatci)
September 27, 2026 11:10
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The merge loop has unreachable handlers and incomplete state handling, while the reindent workflow does not reproduce CI’s pinned formatter.
Review effort: Balanced
Findings: 2
Open (9)
What changed in this PR
Adds reusable Copilot skills for batch merging and style correction, while refining skill discovery documentation.
Changes:
- Adds batch PR merge and reindent workflows.
- Registers both skills in Copilot instructions.
- Shortens the backport skill description.
| File | Description |
|---|---|
.github/skills/citus-merge-loop/SKILL.md |
Defines the merge automation loop. |
.github/skills/citus-check-style-reindent/SKILL.md |
Defines local style correction steps. |
.github/skills/citus-backport/SKILL.md |
Condenses discovery metadata. |
.github/copilot-instructions.md |
Adds skill index entries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Read reviewDecision explicitly instead of vaguely 'PR is not approved'. - Read every check instead of --required: branch protection only requires the aggregate 'CI' job, so check-style and the flakyness jobs never appear there and their special-case rules were unreachable. - Handle the 'cancel' bucket like a failure: rerun it with its own bounded counter, then give up. - Take the PR's changed-file allowlist from 'gh pr diff --name-only' instead of a local diff against a possibly stale origin/<base-branch>. - Rerun failed jobs one at a time via 'gh run rerun --job <databaseId>', each with its own counter, instead of 'gh run rerun --failed'. - Verify the squash-merge actually succeeded before recording 'merged'. - Pin citusdata/tools to style_checker_tools_version too, not just uncrustify; CI runs citus_indent from the stylechecker image built at that exact tag. - Fix the 'no remote lookups' claim in copilot-instructions.md. - Store both SKILL.md files with LF endings: their CRLF endings made ci/editorconfig.sh rewrite them and fail check-style. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Onur Tirtir (onurctirtir)
enabled auto-merge (squash)
September 28, 2026 12:59
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also shorten the description of .github\skills\citus-backport\SKILL.md.