Repository navigation
Show the newest releases' notes as the home page's news - #72
Merged
Merged
Conversation
The news was a hand-written list that stopped at 1.3.1 in 2016. Now Clementine makes a numbered release most weeks, with its notes collected from the commits' Release-note trailers, so the news shows those: the five newest numbered releases from GitHub, each with its notes and a link to it. Development builds are left out, by their tags as well as by being prereleases, since the older ones aren't marked as such. The releases are cached like the rest of what comes from GitHub, and the page shows no news rather than failing when GitHub can't be reached. fetch_android_screenshots's caching for that becomes _load_cached, which both use. Release-note: The website's news shows the notes of Clementine's newest releases. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1jcHj8nGpUkY2WsehhMfh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
The home page's News section was a hand-written list in
data.pythat stopped at 1.3.1 in 2016. Clementine now makes a numbered release most weeks, with notes collected from the commits'Release-note:trailers bydist/release_notes.py, so the news now shows those instead.What changes
1.4.3), each with its date, its notes as a list, and a link to the release on GitHub. Below them, a link to all releases and development builds._load_cached, which both now use.NEWSlist is removed. The heading "Version %(version)s released" and the "All releases and development builds" link are new strings for translators; the notes themselves are in English.One page of 100 releases is fetched, which, with about 17 development builds a week, reaches back around five weekly releases. Today that's only 1.4.3, so the news shows one release until more are made.
Testing
tests/smoke_test.pynow serves a canned release list (a development build, an older non-prerelease build, and two numbered releases) and checks that only the numbered releases' notes are shown, escaped and with their links, and that the home page still loads without news when GitHub fails. It passes locally. I also rendered the home page against the real releases: 1.4.3 shows with its 21 notes.Generated by Claude Code