Repository navigation
Show RPC name in transaction description for inline rpc templates - #257
Merged
Merged
Conversation
An inline device-template-apply (type RPC) was recorded as "rpc-device template (inline)" in "show transactions", so there was no way to tell which RPC it ran. A named template already shows its name. For an inline template, use the name of the RPC element in its config as the description, e.g. "get-bgp-neighbor-information (inline)". The RPC name comes first because the brief "show transactions" table truncates the description to 24 characters. Named templates and all other transactions are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inline device-template-apply (type RPC) was recorded as "rpc-device template (inline)" in "show transactions", so there was no way to tell which RPC it ran. A named template already shows its name.
For an inline template, use the name of the RPC element in its config as the description, e.g. "get-bgp-neighbor-information (inline)". The RPC name comes first because the brief "show transactions" table truncates the description to 24 characters. Named templates and all other transactions are unchanged.