Repository navigation
Conversation
Strict YANG compilers (pyang 2.7.1, yanger) reject clixon-controller@2026-10-01.yang with the following errors, which also blocks tools such as Swagger/OpenAPI generators for any module importing clixon-controller: * augment '/nc:get-config/input/source/config-source' (and the edit-config counterpart): unprefixed nodes in an augment path refer to the current module (RFC 7950 sec 6.5), so 'input', 'source' and 'config-source' were looked up in clixon-controller. Prefix them with 'nc:'. * connection-change input leaf 'operation': 'default 0' is not a valid enumeration value; enum defaults must use the enum name (RFC 7950 sec 9.6.1). Use 'CLOSE', which is the enum with assigned value 0. * device-template-apply input: 'choice template' and its child 'leaf template' share the same identifier namespace (RFC 7950 sec 6.2.1). Rename the choice to 'template-choice'. Choice names do not appear in instance data, so the XML/JSON encoding is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jdad1
force-pushed
the
fix/yang-rfc7950-compliance
branch
from
October 22, 2026 13:34
2f83e80 to
7890b6c
Compare
Author
|
Rebased onto 8804a4b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict YANG compilers (pyang 2.7.1, yanger) reject clixon-controller@2026-06-01.yang with the following errors, which also blocks tools such as Swagger/OpenAPI generators for any module importing clixon-controller:
augment '/nc:get-config/input/source/config-source' (and the edit-config counterpart): unprefixed nodes in an augment path refer to the current module (RFC 7950 sec 6.5), so 'input', 'source' and 'config-source' were looked up in clixon-controller. Prefix them with 'nc:'.
connection-change input leaf 'operation': 'default 0' is not a valid enumeration value; enum defaults must use the enum name (RFC 7950 sec 9.6.1). Use 'CLOSE', which is the enum with assigned value 0.
device-template-apply input: 'choice template' and its child 'leaf template' share the same identifier namespace (RFC 7950 sec 6.2.1). Rename the choice to 'template-choice'. Choice names do not appear in instance data, so the XML/JSON encoding is unchanged.
UPD: Rebased onto current main (
8804a4b).clixon-controller@2026-10-01.yangrevision. The same three issues are still there (now at lines 153, 160, 1114
and 1268), and the fix applies unchanged. The CHANGELOG entry now refers
to
2026-10-01.2026-10-01revision, so released revisions are not edited.test-yang-domain.shwas unrelated. The testhard-coded the openconfig-system revision, and the
clixon/openconfigimagenow ships
2026-07-20. Main already fixes this. Locally, thenacm-yang-othergroup andtest-template.shpass after the rebase.