Repository navigation
Filter transaction notification on controller-transaction - #54
Merged
Merged
Conversation
The controller in post 1.9 send transaction progress information on the transaction stream.
There was a problem hiding this comment.
🟡 Changes recommended
Valid XPath expressions containing XML-special characters produce malformed subscription XML.
1 open issue
What changed in this PR
Filters controller transaction subscriptions so callers receive completion notifications rather than progress updates.
Changes:
- Adds an optional XPath
selectargument to subscription creation. - Applies the filter in both client interfaces.
- Adds a serialization test and changelog entry.
| File | Description |
|---|---|
| tests/test_netconf.py | Tests subscription XPath serialization. |
| clixon/netconf.py | Adds the optional select argument. |
| clixon/clixon.py | Filters transaction notifications in the class interface. |
| clixon/client.py | Filters transaction notifications in the procedural interface. |
| CHANGELOG.md | Documents filtering and controller requirements. |
Review effort: Balanced
| root.rpc.create_subscription.create("stream") | ||
| root.rpc.create_subscription.stream.cdata = stream | ||
| root.rpc.create_subscription.create("filter", {"type": "xpath", "select": ""}) | ||
| root.rpc.create_subscription.create("filter", {"type": "xpath", "select": select}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller in post 1.9 sends transaction progress information on the
transaction stream. This PR filters progress information so that only original transaction end
info is received.