Skip to content

fix: avoid emitting empty rule from block comment - #4921

Merged
mxschll merged 1 commit into
mainfrom
dev-v3-schomax-motion-phantom-rule-fix
Aug 20, 2026
Merged

fix: avoid emitting empty rule from block comment #4921
mxschll merged 1 commit into
mainfrom
dev-v3-schomax-motion-phantom-rule-fix

Conversation

@mxschll

@mxschll mxschll commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

TIL: Because */ ... /* is CSS comment, it gets carried over wherease // is SASS only and will not end up in the output. Because of that, the */ ... /* causes emission of empty rule blocks which we don't want in this case.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll
mxschll marked this pull request as ready for review August 20, 2026 13:06
@mxschll
mxschll requested a review from a team as a code owner August 20, 2026 13:06
@mxschll
mxschll requested review from cansuaa and removed request for a team August 20, 2026 13:06
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (fe20f7a) to head (a8f4fa3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4921   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         958      958           
  Lines       31317    31317           
  Branches    11565    11565           
=======================================
  Hits        30585    30585           
  Misses        725      725           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll
mxschll added this pull request to the merge queue Aug 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 20, 2026
@mxschll
mxschll added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 2910ace Aug 20, 2026
59 checks passed
@mxschll
mxschll deleted the dev-v3-schomax-motion-phantom-rule-fix branch August 20, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants