Repository navigation
V10.2.5/service update - #41
Merged
Merged
Conversation
 [Medium impact] The changes reach library builds, test projects, the public documentation site, and repository release work. Fix the version check before merging so dependency updates can run before a release is tagged.
 |
Replaces the test coverage package with Codebelt.Coverlet.MTP, adds the hang dump extension for diagnosing stuck test runs, and moves the xUnit, test SDK and related packages to their latest stable releases.
The DocFX image now builds from the nginx base and serves the generated site with a repository-specific nginx configuration on port 8080. Fingerprinted DocFX assets are cached permanently, while pages and navigation data are revalidated on every request so a new deployment never shows stale content.
Enables the sitemap with the production base URL, renders API members on separate pages, and adds the ms-style template so the published reference matches the expected layout.
The Copilot instructions duplicated and drifted from AGENTS.md, so the test, benchmark, and XML documentation guidance now lives in AGENTS.md as path-scoped sections. The bot folder notes point only at AGENTS.md.
Records the 10.2.5 patch release with its dependency updates, documentation hosting changes, and consolidated agent guidance, and adds the compare link for the release.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
The workflow derived the next version by scraping CHANGELOG.md, so the branch name and changelog entry could drift from the tags that were actually released. Deriving the version from the latest stable vMAJOR.MINOR.PATCH tag and validating it against the changelog heading keeps branch, changelog, and tag history aligned, and fetching tags makes them available on the runner.
The sitemap pointed at an asp-versioning subdomain that never served the published documentation, so every generated sitemap URL was wrong. Aligning the baseUrl with the canonical versioning.codebelt.net host that the README and package docs already reference makes the sitemap match the live site.
Removing the always flag keeps the one-year immutable Cache-Control directive off error responses, so clients and proxies no longer cache negative results for a year while successful asset responses keep the directive.
Comment on lines
+86
to
+98
| if current_version == next_version and current_status.upper() == "TBD": | ||
| # Reuse an already pending next release, such as [5.0.13] - TBD. | ||
| new_version = next_version | ||
| elif current_version == latest_version and current_status.upper() != "TBD": | ||
| # The changelog is at the latest released tag; start the next patch release. | ||
| new_version = next_version | ||
| else: | ||
| print( | ||
| f"::error::CHANGELOG.md starts at {current_version} ({current_status}), " | ||
| f"but the latest stable Git tag is {latest_tag}. Expected either " | ||
| f"[{latest_version}] with a release date or [{next_version}] - TBD." | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
The new version check rejects a dated release that has not been tagged yet. After this PR merges, CHANGELOG.md will start at dated version 10.2.5. If v10.2.5 has not been created, the latest tag remains v10.2.4. Neither accepted condition matches, so service-update runs stop before updating packages. Allow this between-release state instead of failing the workflow.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-98
Comment:
**Updates stop before tagging**
The new version check rejects a dated release that has not been tagged yet. After this PR merges, `CHANGELOG.md` will start at dated version `10.2.5`. If `v10.2.5` has not been created, the latest tag remains `v10.2.4`. Neither accepted condition matches, so service-update runs stop before updating packages. Allow this between-release state instead of failing the workflow.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comment on lines
+86
to
+88
| if current_version == next_version and current_status.upper() == "TBD": | ||
| # Reuse an already pending next release, such as [5.0.13] - TBD. | ||
| new_version = next_version |
There was a problem hiding this comment.
If CHANGELOG.md starts with the next version marked TBD and PackageReleaseNotes.txt already contains that version's planned changes, the new reuse path selects the same version. The later step then prepends another Version: block without checking for an existing one. Package users get two sections for the same release, separating the planned changes from the dependency-update note. Update the existing block when reusing a release.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-88
Comment:
**Release notes repeat a version**
If `CHANGELOG.md` starts with the next version marked `TBD` and `PackageReleaseNotes.txt` already contains that version's planned changes, the new reuse path selects the same version. The later step then prepends another `Version:` block without checking for an existing one. Package users get two sections for the same release, separating the planned changes from the dependency-update note. Update the existing block when reusing a release.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a service update that focuses on package dependencies.
Automated changes:
Note: Third-party packages (Microsoft.Extensions.*, BenchmarkDotNet, etc.) are not auto-updated.
Use Dependabot or manual updates for those.
Generated by codebelt-aicia
Triggered by: yamldotnet @ 10.1.9