Repository navigation
V10.0.13/service update - #33
Conversation
 [Medium impact] The changes affect this repository's release, documentation, and test workflows. Fix the version check before merging so dependency updates can run between merging release notes and creating the release tag.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The docs image now serves the generated DocFX site through nginx with the repository's cache policy. Fingerprinted assets are cached permanently, while pages and navigation keep stable URLs so they are never served stale after a deploy.
Member pages are split per member for stable deep links, the ms-style template is enabled, and a sitemap is generated for the published documentation site.
Moves test projects to Codebelt.Coverlet.MTP for coverage and adds Microsoft.Testing.Extensions.HangDump for hang diagnostics, replacing the direct code coverage dependency. Also bumps the xunit and test SDK packages to their latest stable releases.
The full test, benchmark, and XML documentation guidance from the Copilot instructions now lives in AGENTS.md with explicit path scopes, so agents read one source of truth.
Release notes for 10.0.13 now describe the dependency updates, the documentation hosting change, and the consolidated agent guidance, and the compare link points at the released tag.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 184 142 -42
Branches 4 4
=========================================
- Hits 184 142 -42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
The grep based version extraction could bump to a patch that already existed or prepend a duplicate section when CHANGELOG.md carried a pending TBD entry. Deriving the next version from the highest stable Git tag and validating it against the changelog heading keeps the generated branch and release entry consistent, and the changelog step now reuses an existing entry instead of writing a second one.
| if current_version == next_version and current_status.upper() == "TBD": | ||
| # Reuse an already pending next release, such as [5.0.13] - TBD. | ||
| new_version = next_version | ||
| elif current_version == latest_version and current_status.upper() != "TBD": | ||
| # The changelog is at the latest released tag; start the next patch release. | ||
| new_version = next_version |
There was a problem hiding this comment.
The version check rejects a dated release entry before its tag exists. After this PR merges but before v10.0.13 is created, CHANGELOG.md starts at dated 10.0.13 while the latest tag remains v10.0.12. Neither condition matches, so incoming service updates and manual runs stop before updating packages.
Allow this gap between merging release notes and creating the release tag.
Knowledge Base Used: Release and downstream coordination
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-91
Comment:
**Updates stop before tagging**
The version check rejects a dated release entry before its tag exists. After this PR merges but before `v10.0.13` is created, `CHANGELOG.md` starts at dated `10.0.13` while the latest tag remains `v10.0.12`. Neither condition matches, so incoming service updates and manual runs stop before updating packages.
Allow this gap between merging release notes and creating the release tag.
**Knowledge Base Used:** [Release and downstream coordination](https://app.greptile.com/geekle/-/custom-context/knowledge-base/codebeltnet/globalization/-/docs/release-and-downstream-coordination.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
| if current_version == next_version and current_status.upper() == "TBD": | ||
| # Reuse an already pending next release, such as [5.0.13] - TBD. | ||
| new_version = next_version |
There was a problem hiding this comment.
If release preparation already added package notes for the pending version, reusing that version makes the package notes step prepend a second block for the same release. Packaging copies the whole file, so both sections reach users and need to be merged by hand.
Update the existing version block when present, just as the new changelog code does.
Knowledge Base Used: Build packaging and release automation
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/service-update.yml
Line: 86-88
Comment:
**Release notes repeat a version**
If release preparation already added package notes for the pending version, reusing that version makes the package notes step prepend a second block for the same release. Packaging copies the whole file, so both sections reach users and need to be merged by hand.
Update the existing version block when present, just as the new changelog code does.
**Knowledge Base Used:** [Build packaging and release automation](https://app.greptile.com/geekle/-/custom-context/knowledge-base/codebeltnet/globalization/-/docs/build-packaging-and-release-automation.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
3 participants
This is a service update that focuses on package dependencies.
Automated changes:
Note: Third-party packages (Microsoft.Extensions.*, BenchmarkDotNet, etc.) are not auto-updated.
Use Dependabot or manual updates for those.
Generated by codebelt-aicia
Triggered by: yamldotnet @ 10.1.9