feat(windows-rdp): add native client option - #1092
Open
Edd88-pixel wants to merge 3 commits into
Open
Conversation
Edd88-pixel
marked this pull request as ready for review
September 2, 2026 08:25
matifali
requested changes
Sep 2, 2026
matifali
reviewed
Sep 2, 2026
Collaborator
|
I think the one main thing that I notice here @Edd88-pixel is that this isn't really an opt-in change as the PR describes its defaulted to true so its something that will be enforced for anyone using this new module version. |
Contributor
Author
|
I’ll update the PR description to reflect that native RDP is enabled by default now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
windows-rdpmodule currently exposes only the browser-based client. This change also provides a one-click native RDP experience through Coder Desktop.Native RDP is enabled by default. Existing users who want to keep web-only access can set
enable_native_rdp = false.Changes
RDP Desktopapp, enabled by default, using the existing Coder Desktopcoder://RDP URI patternagent_name, required when native RDP is enabled, with cross-variable validation and a Terraform minimum version of 1.9enable_native_rdp = falsewhile preserving the existing Web RDP app1.4.0usage examplesValidation
terraform fmt -check— passedterraform validate— passedterraform test— 3 passed, 0 failedRDP Desktoplink rendered with the expectedcoder://.../agent/main/rdpURIDescription
Adds native RDP access through Coder Desktop by default while keeping the existing Web RDP app available. Consumers must provide
agent_namewhen native RDP is enabled, or setenable_native_rdp = falsefor web-only access.Type of Change
Module Information
Path:
registry/coder/modules/windows-rdpNew version:
v1.4.0Breaking change: [x] Yes [ ] No
Compatibility note: upgrading consumers must provide
agent_nameor explicitly disable native RDP. The module now requires Terraform 1.9 or newer.Testing & Validation
terraform testandbun test)terraform fmt -check)Related Issues
Closes #1061