Skip to content

feat(windows-rdp): add native client option - #1092

Open
Edd88-pixel wants to merge 3 commits into
coder:mainfrom
Edd88-pixel:eddy/windows-rdp-native-client
Open

feat(windows-rdp): add native client option#1092
Edd88-pixel wants to merge 3 commits into
coder:mainfrom
Edd88-pixel:eddy/windows-rdp-native-client

Conversation

@Edd88-pixel

@Edd88-pixel Edd88-pixel commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Why

The windows-rdp module currently exposes only the browser-based client. This change also provides a one-click native RDP experience through Coder Desktop.

Native RDP is enabled by default. Existing users who want to keep web-only access can set enable_native_rdp = false.

Changes

  • add an RDP Desktop app, enabled by default, using the existing Coder Desktop coder:// RDP URI pattern
  • add agent_name, required when native RDP is enabled, with cross-variable validation and a Terraform minimum version of 1.9
  • allow users to opt out of the native app with enable_native_rdp = false while preserving the existing Web RDP app
  • URL-encode the administrator username and password passed to the native client
  • add a dedicated native RDP icon and a configurable tooltip explaining the Coder Desktop requirement
  • add Terraform coverage for the disabled state, the required agent name, and the default-enabled state
  • document the default behavior, web-only opt-out, Coder Desktop prerequisite, and 1.4.0 usage examples

Validation

  • terraform fmt -check — passed
  • terraform validate — passed
  • terraform test — 3 passed, 0 failed
  • integrated-browser validation — one visible and enabled RDP Desktop link rendered with the expected coder://.../agent/main/rdp URI

Description

Adds native RDP access through Coder Desktop by default while keeping the existing Web RDP app available. Consumers must provide agent_name when native RDP is enabled, or set enable_native_rdp = false for web-only access.

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/windows-rdp
New version: v1.4.0
Breaking change: [x] Yes [ ] No

Compatibility note: upgrading consumers must provide agent_name or explicitly disable native RDP. The module now requires Terraform 1.9 or newer.

Testing & Validation

  • Tests pass (terraform test and bun test)
  • Code formatted (terraform fmt -check)
  • Changes tested locally

Related Issues

Closes #1061

@Edd88-pixel
Edd88-pixel marked this pull request as ready for review September 2, 2026 08:25
Comment thread registry/coder/modules/windows-rdp/main.tf Outdated
Comment thread registry/coder/modules/windows-rdp/main.tf Outdated
Comment thread registry/coder/modules/windows-rdp/README.md Outdated
Comment thread registry/coder/modules/windows-rdp/main.tf
Comment thread registry/coder/modules/windows-rdp/main.tf Outdated
Comment thread registry/coder/modules/windows-rdp/main.tf
Comment thread registry/coder/modules/windows-rdp/main.tf
@DevelopmentCats

Copy link
Copy Markdown
Collaborator

I think the one main thing that I notice here @Edd88-pixel is that this isn't really an opt-in change as the PR describes its defaulted to true so its something that will be enforced for anyone using this new module version.

@Edd88-pixel

Copy link
Copy Markdown
Contributor Author

I’ll update the PR description to reflect that native RDP is enabled by default now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-rdp: Add option to open in native RDP desktop client

3 participants