fix(git-clone): scan custom SSH ports - #1093
Open
35C4n0r wants to merge 1 commit into
Open
Conversation
35C4n0r
marked this pull request as ready for review
September 3, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The git-clone module scanned SSH host keys on port 22 even when an
ssh://repository URL specified a custom port, causing host-key verification to fail for self-hosted Git services on ports such as 2222.Parse the host and port from
ssh://URLs, use the port-specific[host]:portidentity for known-host lookups, and pass the port tossh-keyscan. Preserve scp-style URL behavior and add regression coverage for custom-port and existing-key cases.Type of Change
Module Information
Path:
registry/coder/modules/git-cloneNew version:
v2.0.4Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Fixes #1073
Generated by Coder Agents for @35C4n0r.