Skip to content

test(widget): pass the widget tests on Node 25 - #211

Merged
anurag629 merged 6 commits into
devfrom
test/widget-node-25
Nov 18, 2026
Merged

anurag629 merged 6 commits into
devfrom
test/widget-node-25

Conversation

@anurag629

Copy link
Copy Markdown
Member

What does this change?

Node 25 turned on its own localStorage, and it hides happy-dom's in the widget tests, so 42 of the 222 fail with localStorage.clear is not a function. The widget's test config now starts the test workers with --no-experimental-webstorage on Node 25 and later, and happy-dom's storage is used again. Node 22 and 24 don't get the flag.

CONTRIBUTING says Node.js 22 or newer, so contributors on the current Node release run into this first. Saifjafri212213 hit it while working on #205.

How I tested this

  • Node 25.9.0: the widget tests pass, 222 of 222 (42 failed before), and so does pnpm test for the whole repo (35 files, 415 tests).
  • Node 22.23.3 and 24.12.0: the widget tests pass, 222 of 222.
  • pnpm -r build and pnpm -r typecheck on Node 22.

No changeset: nothing under packages/*/src changes.

anurag629 and others added 3 commits October 20, 2026 10:40
Node 25 turned on its own localStorage, which hides happy-dom's, so 42 of
the 222 widget tests failed with "localStorage.clear is not a function".
Start the test workers with --no-experimental-webstorage on Node 25 and
later. Node 22 and 24 don't get the flag.
# Conflicts:
#	packages/widget/vite.config.ts
@anurag629

Copy link
Copy Markdown
Member Author

Merged dev in and kept dev's typecheck block next to the execArgv line. It's still needed: on current dev, 351 of the 943 widget tests fail on Node 25.9.0 with localStorage.clear is not a function. With this, all 943 pass on 25.9.0 and on 24.12.0.

@anurag629
anurag629 merged commit 8c16fc3 into dev Nov 18, 2026
5 checks passed
@anurag629
anurag629 deleted the test/widget-node-25 branch November 18, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant