Repository navigation
feat(templates): add product-you-asked template - #427
Open
Saumyajaiswal9794 wants to merge 1 commit into
Open
Saumyajaiswal9794 wants to merge 1 commit into
Saumyajaiswal9794 wants to merge 1 commit into
Conversation
anurag629
requested changes
Nov 17, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Hey @Saumyajaiswal9794, nice work, the card does what #402 asks: a blank request hides it and the pill and title move up, the vote label only shows with a count, a blank version gives "Shipped", and a long vote count truncates without stretching the box. The pill, border and count read fine on the light background too.
A few things before I can merge:
- In the long preview the pill wraps onto three lines across the whole card, because
versionisn't truncated (src/templates/product/you-asked.ts:63) and the pill span at :198 can wrap. Please truncate the version (24 characters is plenty) and keep the pill on one line withwhiteSpace: 'nowrap',overflow: 'hidden'andtextOverflow: 'ellipsis'. - The site name wraps onto three lines in the long preview too. Truncate it the way Waitlist does (
src/templates/product/waitlist.ts:51cuts it at 40) and keep the span at :229 on one line. Please add a test for the long version and the long site name. - A long vote label wraps onto a second line inside the vote box (:116). The same
whiteSpace: 'nowrap'andtextOverflow: 'ellipsis'keeps it on one line under the count. - Small one:
registry.tsis missing the space inproductWaitlist,productYouAsked,, andsrc/templates/product/index.tslost the newline at the end of the file.
Everything else looks good.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
product-you-askedtemplate (src/templates/product/you-asked.ts) for posts announcing a feature users asked for: a request card with a vote box and the quoted request, a "Shipped in vX" pill, the title and the site name.src/templates/product/index.tsand registered in the product block ofregistry.tstests/templates/you-asked.test.tsCloses #402
Screenshots
PNGs exported from the editor with Download PNG (1200x630).
Defaults
Light background
Long text
All optional fields empty
How I Tested This
npm run check: 0 errorsnpm run test: all tests pass, exceptagenda.test.ts, which times out on a cold run on my Windows machine and passes when run alone (unrelated to this change)npm run devand checked the template at/create/product:#FFFFFF/#111111): pill, border and vote count stay readableAI Assistance
I used an AI coding agent in VS Code (GitHub Copilot / Auto mode) to generate the template and its tests, based on the issue spec and the existing templates in the repo (
waitlist.ts,discussion.ts). I used Claude to help write the prompt for the agent and for git/PR guidance. I reviewed the generated code, rannpm run checkandnpm run test, and tested every acceptance criterion manually in the editor.