Skip to content

ci: move artifact actions to Node 24 releases - #70

Closed
sanchitrk wants to merge 1 commit into
canaryfrom
ci/node24-artifacts
Closed

sanchitrk wants to merge 1 commit into
canaryfrom
ci/node24-artifacts

Conversation

@sanchitrk

Copy link
Copy Markdown
Contributor

Summary

GitHub runners warn that actions/upload-artifact@v4 targets Node.js 20 and is being forced onto Node.js 24. This moves both artifact actions to releases that run on Node 24:

  • actions/upload-artifact@v4 → @v7 (tui.yml)
  • actions/download-artifact@v4 → @v8 (canary.yml)

The breaking changes in between don't affect these workflows:

  • v5 changed the path layout for downloads by ID. We download by name pattern (tui-*), which keeps one directory per artifact.
  • v7 added an optional archive: false; the default is unchanged.
  • v8 fails on a digest mismatch instead of warning, which is the safer default for binaries we publish.

The other actions are already on Node 24 (checkout@v6, rust-cache@v2, setup-vp@v1.21.1), and dtolnay/rust-toolchain is a composite action with no Node runtime.

Test plan

  • vp check
  • The TUI Binaries run on this PR uploads all four artifacts with no Node 20 warning
  • The next canary run downloads them and publishes

🤖 Generated with Claude Code

upload-artifact v4 and download-artifact v4 target Node 20, which GitHub
runners now force onto Node 24 with a deprecation warning. v7 and v8 run
on Node 24. Their breaking changes don't apply here: downloads are by
name pattern, not ID, and v8 now fails on a digest mismatch instead of
warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sanchitrk

Copy link
Copy Markdown
Contributor Author

Pushed directly to canary instead.

@sanchitrk sanchitrk closed this Oct 11, 2026
@sanchitrk
sanchitrk deleted the ci/node24-artifacts branch October 11, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant