Skip to content

docs(android): enhance multimedia attachment#430

Merged
ketanyekale merged 10 commits into
mainfrom
feature/android-multimedia-attachments
Jul 24, 2026
Merged

docs(android): enhance multimedia attachment#430
ketanyekale merged 10 commits into
mainfrom
feature/android-multimedia-attachments

Conversation

@hritika-cometchat

@hritika-cometchat hritika-cometchat commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cometchat 🟢 Ready View Preview Jul 15, 2026, 2:02 PM

@mintlify

mintlify Bot commented Jul 15, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cometchat 🟡 Building Jul 15, 2026, 1:57 PM

@hritika-cometchat hritika-cometchat changed the title docs: enhance multimedia attachment docs(android): enhance multimedia attachment Jul 22, 2026
suraj-chauhan-cometchat added a commit that referenced this pull request Jul 23, 2026
…haring

Add the multi_attachments_mobile.png screenshot (shared with the Android
multi-attachment docs, PR #430) and reference it in the core-features
Media Sharing section, replacing the older single-media image.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
suraj-chauhan-cometchat added a commit that referenced this pull request Jul 23, 2026
…setMuid

Match the Android multi-attachment guide (PR #430): call
mediaMessage.setMuid(request.getBatchId()) in the upload-then-send example
so the sent MediaMessage is tied to its upload batch. setMuid() is inherited
from BaseMessage in @cometchat/chat-sdk-react-native.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
adityakotasthane07 added a commit that referenced this pull request Jul 23, 2026
Mirror the Android multimedia-attachments docs (PR #430) for iOS:

- sdk/ios/upload-files: new dedicated page for the UploadFileRequest
  upload-then-send flow — create request, uploadAttachments with
  caller-supplied fileIds, UploadFileListener (onFileProgress/
  onFileUploaded/onFileError/onFileFailure/onComplete), UploadResult,
  configuration setters, per-call + global listeners, batch getters,
  remove/retry/clear, limits, reliability behavior, and the error table
- sdk/ios/send-message: slim the Multiple Attachments section to the
  upload-first tip plus the two direct-send forms (files array and
  pre-hosted Attachment objects)
- docs.json: register sdk/ios/upload-files after send-message
- ui-kit/ios/core-features: add the multi-attachment overview screenshot
  to the Media Sharing section
suraj-chauhan-cometchat added a commit that referenced this pull request Jul 24, 2026
…lign Media Sharing with Android

- audios-bubble: document expandButtonTextStyle (now exposed by audiosBubbleStyles)
- images/videos-bubble: CometChatMediaViewer as plain text (no MediaViewer page to link)
- images-bubble: drop mislinked "Image Bubble" -> message-bubble-styling, plain text like siblings
- all bubble/composer/list pages: remove 7 empty screenshot TODO comment markers
- core-features Media Sharing: mirror Android PR #430 copy, table anchors, and split/grouping note

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — ✅ Approve (one small nit)

Android multi-attachment docs — the Android counterpart of #428 (iOS), with a new 578-line upload-files.mdx. I verified the entire API against the matching SDK branch (origin/ENG-36734) and it's precise.

✅ API — verified against origin/ENG-36734

  • CometChat.createUploadFileRequest(@NonNull String receiverId, …)CometChat.java:2303
  • CometChat.getMaxAttachmentCount(): int (:2317) and getMaxFileSize(): long (:2329)
  • UploadFileRequest (:64) with addUploadListener(UploadFileListener) (:245) and removeUploadListener() — no-arg (:250). The doc uses the no-arg form correctly and accurately documents the single-global-slot semantics ("a later addUploadListener() replaces the previous; removeUploadListener() clears it").
  • uploadAttachments(List<UploadFileItem>, UploadFileListener) plus the Context overload — the doc covers both and correctly explains why Uri-backed items need Context (to resolve name/size/mime type).
  • MediaMessage.getAttachments() / setAttachments(List<Attachment>)MediaMessage.java:239/243
  • UploadResult + onComplete(UploadResult result) — matches the SDK's own javadoc example verbatim.
  • Platform correctness: uses Android's createUploadFileRequest / getMaxAttachmentCount / UploadFileListener rather than iOS's uploadFiles / getMaxFileCount / MediaCallbackListener. That's a real platform difference and it's handled right — an easy thing to get wrong when porting docs across platforms. 👍

✅ Structure

New sdk/android/v5/upload-files is wired into nav; 0 nav breaks, 0 orphans, redirects +0. (The 2 broken links the analyzer flagged — /sdk/android/calling-setup, /sdk/android/default-calling — are pre-existing, in unchanged files.)

🟡 Nit — unreferenced image

images/multi_attachments_mobile.png is added but not referenced anywhere in the repo (grepped repo-wide). Either it was meant to be embedded in one of the UI Kit pages (message-composer / core-features) and the embed was missed, or it's a leftover — worth adding the embed or dropping the file.

Note

As with #428 (iOS), the SDK feature lives on a feature branch (ENG-36734) — please confirm the SDK version with createUploadFileRequest / getMaxAttachmentCount ships with the release these docs target.

High-quality, precisely-sourced PR. Ready to merge. 🚀

🤖 Automated docs review (Mintlify link/redirect/content checks + API verification against chat-sdk-android multi-attachment branch).

jitvarpatil
jitvarpatil previously approved these changes Jul 24, 2026

@jitvarpatil jitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review — ✅ Approve (one small nit)

Android multi-attachment docs — the Android counterpart of #428 (iOS), with a new 578-line upload-files.mdx. I verified the entire API against the matching SDK branch (origin/ENG-36734) and it's precise.

✅ API — verified against origin/ENG-36734

  • CometChat.createUploadFileRequest(@NonNull String receiverId, …)CometChat.java:2303
  • CometChat.getMaxAttachmentCount(): int (:2317) and getMaxFileSize(): long (:2329)
  • UploadFileRequest (:64) with addUploadListener(UploadFileListener) (:245) and removeUploadListener() — no-arg (:250). The doc uses the no-arg form correctly and accurately documents the single-global-slot semantics ("a later addUploadListener() replaces the previous; removeUploadListener() clears it").
  • uploadAttachments(List<UploadFileItem>, UploadFileListener) plus the Context overload — the doc covers both and correctly explains why Uri-backed items need Context (to resolve name/size/mime type).
  • MediaMessage.getAttachments() / setAttachments(List<Attachment>)MediaMessage.java:239/243
  • UploadResult + onComplete(UploadResult result) — matches the SDK's own javadoc example verbatim.
  • Platform correctness: uses Android's createUploadFileRequest / getMaxAttachmentCount / UploadFileListener rather than iOS's uploadFiles / getMaxFileCount / MediaCallbackListener. That's a real platform difference and it's handled right — an easy thing to get wrong when porting docs across platforms. 👍

✅ Structure

New sdk/android/v5/upload-files is wired into nav; 0 nav breaks, 0 orphans, redirects +0. (The 2 broken links the analyzer flagged — /sdk/android/calling-setup, /sdk/android/default-calling — are pre-existing, in unchanged files.)

🟡 Nit — unreferenced image

images/multi_attachments_mobile.png is added but not referenced anywhere in the repo (grepped repo-wide). Either it was meant to be embedded in one of the UI Kit pages (message-composer / core-features) and the embed was missed, or it's a leftover — worth adding the embed or dropping the file.

Note

As with #428 (iOS), the SDK feature lives on a feature branch (ENG-36734) — please confirm the SDK version with createUploadFileRequest / getMaxAttachmentCount ships with the release these docs target.

High-quality, precisely-sourced PR. Ready to merge. 🚀

🤖 Automated docs review (Mintlify link/redirect/content checks + API verification against chat-sdk-android multi-attachment branch).

@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

My earlier approval was auto-dismissed by the new commits, so re-reviewing on head cfe50bf (PR grew 8 → 12 files).

✅ Earlier nit fixed

images/multi_attachments_mobile.png is now referenced in ui-kit/android/v6/core-features.mdx (via the "add multi-attachment overview screenshot" commit). 👍

✅ New content checks out

  • The 4 new bubble images (audiobubble, filesbubble, imagesbubble, videosbubble) are all referenced by message-bubble-styling.mdx, with descriptive alt text.
  • All image references in the changed Android pages resolve — 0 missing.
  • Structure still clean: 0 nav breaks, 0 orphans, 0 broken links, redirects +0.
  • upload-files.mdx unchanged (578 lines) — API already verified against ENG-36734 (createUploadFileRequest, getMaxAttachmentCount/getMaxFileSize, UploadFileRequest + no-arg removeUploadListener(), both uploadAttachments overloads, MediaMessage.setAttachments, UploadResult).

🟡 One thing to confirm — this PR overwrites a shared image

images/multi_attachments_mobile.png already exists in main and is referenced there by ui-kit/react-native/core-features.mdx. The commit "update multi-attachment overview image for mobile display" replaces that file's content — so the React Native page's screenshot changes too when this merges.

Please confirm the updated image is still appropriate for the RN page. If it's now Android-specific, give it an Android-specific filename instead so the two platforms don't share one asset.

(This also corrects a note I left on #432: since the file pre-exists in main, this is an overwrite of a shared asset — not a duplicate binary add between the two PRs.)

Everything else verifies. Ready to merge. 🚀

🤖 Automated docs review — re-check after new commits.

@jitvarpatil jitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

My earlier approval was auto-dismissed by the new commits, so re-reviewing on head cfe50bf (PR grew 8 → 12 files).

✅ Earlier nit fixed

images/multi_attachments_mobile.png is now referenced in ui-kit/android/v6/core-features.mdx (via the "add multi-attachment overview screenshot" commit). 👍

✅ New content checks out

  • The 4 new bubble images (audiobubble, filesbubble, imagesbubble, videosbubble) are all referenced by message-bubble-styling.mdx, with descriptive alt text.
  • All image references in the changed Android pages resolve — 0 missing.
  • Structure still clean: 0 nav breaks, 0 orphans, 0 broken links, redirects +0.
  • upload-files.mdx unchanged (578 lines) — API already verified against ENG-36734 (createUploadFileRequest, getMaxAttachmentCount/getMaxFileSize, UploadFileRequest + no-arg removeUploadListener(), both uploadAttachments overloads, MediaMessage.setAttachments, UploadResult).

🟡 One thing to confirm — this PR overwrites a shared image

images/multi_attachments_mobile.png already exists in main and is referenced there by ui-kit/react-native/core-features.mdx. The commit "update multi-attachment overview image for mobile display" replaces that file's content — so the React Native page's screenshot changes too when this merges.

Please confirm the updated image is still appropriate for the RN page. If it's now Android-specific, give it an Android-specific filename instead so the two platforms don't share one asset.

(This also corrects a note I left on #432: since the file pre-exists in main, this is an overwrite of a shared asset — not a duplicate binary add between the two PRs.)

Everything else verifies. Ready to merge. 🚀

🤖 Automated docs review — re-check after new commits.

@ketanyekale
ketanyekale merged commit 37055fb into main Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants