docs(android): enhance multimedia attachment#430
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
…and live previews
…haring Add the multi_attachments_mobile.png screenshot (shared with the Android multi-attachment docs, PR #430) and reference it in the core-features Media Sharing section, replacing the older single-media image. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…setMuid Match the Android multi-attachment guide (PR #430): call mediaMessage.setMuid(request.getBatchId()) in the upload-then-send example so the sent MediaMessage is tied to its upload batch. setMuid() is inherited from BaseMessage in @cometchat/chat-sdk-react-native. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirror the Android multimedia-attachments docs (PR #430) for iOS: - sdk/ios/upload-files: new dedicated page for the UploadFileRequest upload-then-send flow — create request, uploadAttachments with caller-supplied fileIds, UploadFileListener (onFileProgress/ onFileUploaded/onFileError/onFileFailure/onComplete), UploadResult, configuration setters, per-call + global listeners, batch getters, remove/retry/clear, limits, reliability behavior, and the error table - sdk/ios/send-message: slim the Multiple Attachments section to the upload-first tip plus the two direct-send forms (files array and pre-hosted Attachment objects) - docs.json: register sdk/ios/upload-files after send-message - ui-kit/ios/core-features: add the multi-attachment overview screenshot to the Media Sharing section
…lign Media Sharing with Android - audios-bubble: document expandButtonTextStyle (now exposed by audiosBubbleStyles) - images/videos-bubble: CometChatMediaViewer as plain text (no MediaViewer page to link) - images-bubble: drop mislinked "Image Bubble" -> message-bubble-styling, plain text like siblings - all bubble/composer/list pages: remove 7 empty screenshot TODO comment markers - core-features Media Sharing: mirror Android PR #430 copy, table anchors, and split/grouping note Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Docs review — ✅ Approve (one small nit)Android multi-attachment docs — the Android counterpart of #428 (iOS), with a new 578-line ✅ API — verified against
|
jitvarpatil
left a comment
There was a problem hiding this comment.
Docs review — ✅ Approve (one small nit)
Android multi-attachment docs — the Android counterpart of #428 (iOS), with a new 578-line upload-files.mdx. I verified the entire API against the matching SDK branch (origin/ENG-36734) and it's precise.
✅ API — verified against origin/ENG-36734
CometChat.createUploadFileRequest(@NonNull String receiverId, …)—CometChat.java:2303CometChat.getMaxAttachmentCount(): int(:2317) andgetMaxFileSize(): long(:2329)UploadFileRequest(:64) withaddUploadListener(UploadFileListener)(:245) andremoveUploadListener()— no-arg (:250). The doc uses the no-arg form correctly and accurately documents the single-global-slot semantics ("a lateraddUploadListener()replaces the previous;removeUploadListener()clears it").uploadAttachments(List<UploadFileItem>, UploadFileListener)plus theContextoverload — the doc covers both and correctly explains why Uri-backed items needContext(to resolve name/size/mime type).MediaMessage.getAttachments()/setAttachments(List<Attachment>)—MediaMessage.java:239/243UploadResult+onComplete(UploadResult result)— matches the SDK's own javadoc example verbatim.- Platform correctness: uses Android's
createUploadFileRequest/getMaxAttachmentCount/UploadFileListenerrather than iOS'suploadFiles/getMaxFileCount/MediaCallbackListener. That's a real platform difference and it's handled right — an easy thing to get wrong when porting docs across platforms. 👍
✅ Structure
New sdk/android/v5/upload-files is wired into nav; 0 nav breaks, 0 orphans, redirects +0. (The 2 broken links the analyzer flagged — /sdk/android/calling-setup, /sdk/android/default-calling — are pre-existing, in unchanged files.)
🟡 Nit — unreferenced image
images/multi_attachments_mobile.png is added but not referenced anywhere in the repo (grepped repo-wide). Either it was meant to be embedded in one of the UI Kit pages (message-composer / core-features) and the embed was missed, or it's a leftover — worth adding the embed or dropping the file.
Note
As with #428 (iOS), the SDK feature lives on a feature branch (ENG-36734) — please confirm the SDK version with createUploadFileRequest / getMaxAttachmentCount ships with the release these docs target.
High-quality, precisely-sourced PR. Ready to merge. 🚀
🤖 Automated docs review (Mintlify link/redirect/content checks + API verification against chat-sdk-android multi-attachment branch).
Re-review — ✅ ApproveMy earlier approval was auto-dismissed by the new commits, so re-reviewing on head ✅ Earlier nit fixed
✅ New content checks out
🟡 One thing to confirm — this PR overwrites a shared image
Please confirm the updated image is still appropriate for the RN page. If it's now Android-specific, give it an Android-specific filename instead so the two platforms don't share one asset. (This also corrects a note I left on #432: since the file pre-exists in Everything else verifies. Ready to merge. 🚀 🤖 Automated docs review — re-check after new commits. |
jitvarpatil
left a comment
There was a problem hiding this comment.
Re-review — ✅ Approve
My earlier approval was auto-dismissed by the new commits, so re-reviewing on head cfe50bf (PR grew 8 → 12 files).
✅ Earlier nit fixed
images/multi_attachments_mobile.png is now referenced in ui-kit/android/v6/core-features.mdx (via the "add multi-attachment overview screenshot" commit). 👍
✅ New content checks out
- The 4 new bubble images (
audiobubble,filesbubble,imagesbubble,videosbubble) are all referenced bymessage-bubble-styling.mdx, with descriptive alt text. - All image references in the changed Android pages resolve — 0 missing.
- Structure still clean: 0 nav breaks, 0 orphans, 0 broken links, redirects +0.
upload-files.mdxunchanged (578 lines) — API already verified againstENG-36734(createUploadFileRequest,getMaxAttachmentCount/getMaxFileSize,UploadFileRequest+ no-argremoveUploadListener(), bothuploadAttachmentsoverloads,MediaMessage.setAttachments,UploadResult).
🟡 One thing to confirm — this PR overwrites a shared image
images/multi_attachments_mobile.png already exists in main and is referenced there by ui-kit/react-native/core-features.mdx. The commit "update multi-attachment overview image for mobile display" replaces that file's content — so the React Native page's screenshot changes too when this merges.
Please confirm the updated image is still appropriate for the RN page. If it's now Android-specific, give it an Android-specific filename instead so the two platforms don't share one asset.
(This also corrects a note I left on #432: since the file pre-exists in main, this is an overwrite of a shared asset — not a duplicate binary add between the two PRs.)
Everything else verifies. Ready to merge. 🚀
🤖 Automated docs review — re-check after new commits.
Description
Related Issue(s)
Type of Change
Checklist
Additional Information
Screenshots (if applicable)