Tracking issue: GLFW patch for improved fullscreen compatibility

[comp500]

I'm working on a patch to GLFW that will improve borderless fullscreen compatibility using different window flags. I've been looking into the issues with current fullscreen methods Borderless Mining (and similar mods) uses, and I hope that these changes will fix some of the issues people have with the mod currently (including #1 #2 #3 #9).

These patches will only have effect on Windows - if you're experiencing issues on other operating systems, please report them separately.

As I am rather busy currently, I have no timeline or guarantee for these changes to be implemented; but please subscribe to this issue (using the button on the right) for updates and test builds.

[comp500]

The GLFW replacement test 1 build is now available! Get it for Fabric 1.18: borderless-mining-2.0.0-alpha-dev.0d42a0d+1.18.jar.zip (in a zip because GitHub restricts the file type)

Since fullscreen behaviour on Windows is often affected by driver heuristics and multi-monitor quirks, I don't know how all configurations will behave with these changes. Hence, please test this build and let me know your experience! I'm curious to know if any of the following break/occur with your configuration:

• Overlays (e.g. Xbox Game Bar, NVIDIA Share, Discord, Steam)
• Input Method Editors (IMEs, e.g. for Chinese input)
• Screenshots from external applications
• Excessive tearing (worse than standard fullscreen with VSync)
• Game minimises when you click in another monitor
• Taskbar displays on top of the game, when the game is selected
• Windows cannot be placed on top of the game
• Framerate forced to VSync/display framerate when VSync is disabled (please check if this does not occur in exclusive fullscreen without VSync first)

If you encounter any issues with these builds, please test to see if you can reproduce the issues with the following changes:

• If you have multiple graphics processors (especially with hybrid/laptop graphics) change which is used for javaw.exe and check in the F3 screen (https://www.howtogeek.com/351522/how-to-choose-which-gpu-a-game-uses-on-windows-10/)
• If you use multiple monitors, try changing which monitor you use Minecraft on, and changing the primary monitor
• Test with other OpenGL games/applications (https://www.pcgamingwiki.com/wiki/List_of_OpenGL_games - though many of these use DirectX on Windows and OpenGL on other OSes)

I ask that you do not distribute this build (and future test builds) in public modpacks; as the changes are experimental and the current build crashes on any OS other than Windows!

Source: 0d42a0d
Source for glfw3.dll: comp500/glfw@08b3a9e

(cc: @cpm9 @kosma @NeusFear @ZenoMetal @fortemfiducia @juliand665)

[comp500]

Oh, and one more thing to note: this build completely removes all of the Borderless Mining interface, instead replacing the standard fullscreen option with borderless fullscreen! I may add some of or all the previous features back, depending on what works best for different configurations (but no guarantees).

[kosma]

Tested under the following setup:

• Win10, GTX 1660S, roughly recent drivers
• Fabric 1.18.1, heavily modded (including Sodium/Indium/Iris/Continuity)
• Single monitor but with 125% text scaling
• Tried Discord and Geforce overlays + Win-Shift-S screenshots at the same time

Found no issues. I wish I could compare to non-patched 1.18.1 so I could look for the tearing a bit harder

I will use my friends as guinea pigs for testing this - private modpack, ca. 10-15 users.

PS. I love the removal of GUI, and just flat out replacing the fullscreen functionality - minimalistic but fully functional (and also I think playing nicely with the Video Settings GUI modifications done by Sodium).

[Arcensoth]

Just discovered this mod today, looking for a solution to the curious fact that my FPS drops dramatically with the vanilla true fullscreen enabled.

The current stable release kept my FPS stable in borderless fullscreen mode, but caused significant screen tearing as described in #1. Looks like I stumbled across this mod and the test build at the perfect time!

Relevant specs:

• Windows 10, build 19043
• GeForce GTX 1060 6GB, driver version 456.71
• Java 17.0.1 64bit, 2GB allocated
• Single ultrawide display (2560x1080)
• Fabric 1.18, client modded (Sodium, Phosphor, Lithium, Iris, BSL shaders)
• VSync enabled, render distance 8-12

Things I've noticed:

• No drop in FPS compared to bordered windowed mode (same as current stable release)
• Windows screenshot and gamebar overlays work well
• No excessive tearing (if any at all), as opposed to the current stable release where it is abundant
• Game does not minimize when taskbar is selected - as expected
• Taskbar does not display on top of the game, when the game is selected - as expected
• Windows can be placed on top of the game - as expected

Awesome work! I haven't been able to play in ultrawide fullscreen without sacrificing some visual component (render distance, shaders, etc) in some time, and I'm hyped to longer have to make a choice. :)

[kosma]

Did extra testing:

• MSI Afterburner overlay - works
• Multi-monitor - works
• SEUS shaders - works
• No noticeable performance difference with and without the mod

[kosma]

Side note, probably obvious - crashes on macOS because it can't locate the DLL file.

[he3als]

I have had no issues previously with borderless mining. Here I will compare fullscreen exclusive and this test of Borderless Mining on 1.18.1.

Relevant specs & info:

• Windows 10 21H2 (OS Build 19044.1288)
• NVIDIA GeForce GTX 970 - 497.29 DCH (installed with NVCleanstall)
• GraalVM Community Edition 17 - 21.3.0 - Java Arguments (some are added by MultiMC)
• MultiMC development branch - 0.6.14-develop-3122
• Two monitors - 240hz and 75hz (both 1080p)
• Fabric 1.18.1 - Mods list
• V-Sync disabled in-game, render distance 8 and simulation distance 6
• CapFrameX used to benchmark
• Windows Game Mode is on
• Shaders turned off

Benchmarking Results

In each benchmark, I opened a world and walked 25 blocks to the exact same point and then waited for the capture to end in CapFrameX (20 seconds). I did each benchmark fairly and started and stopped at the same place each time.

Averages (mean)

Fullscreen Exclusive (FSE)

• Average FPS: 681.5 FPS
• 1% percentile FPS: 335.366666667 FPS
• 0.1% percentile FPS: 245.533333333 FPS
• Score (adding them all up): 1262.4

Borderless Mining (BM)

• Average FPS: 583.3 FPS
• 1% percentile FPS: 312.7 FPS
• 0.1% percentile FPS: 236.966666667 FPS
• Score (adding them all up): 1132.96666667

Things I've noticed:

• ShareX screenshot previews work (in the bottom right corner), so overlays work
• I do not notice any tearing, even if V-Sync is disabled everywhere
• Game does not minimize when the taskbar or another application is clicked/focused - as expected
• Taskbar does not display on top of the game, when the game is selected - as expected
• Windows can be placed on top of the game - as expected

[SleepyCatten]

Thank you soooo much for producing this version. I've tested this now for several hours without any issues 🥰 My setup is as follows:

RTX 2070 Super (511.23 drivers)
Windows 10 Pro 64-bit (21H2 - build 19044.1348)
Ryzen 7 5800X
Fabric loader (installer version 0.10.2)
Minecraft 1.18.1

I have not done any benchmarks, but I've noticed no noticeable slowdown between this mode and regular windowed mode.

[Azim]

This fixed my tearing issues. My setup:

Minecraft 1.18.1 with sodium, lithium, and etc optimization mods
2 monitors with Minecraft being on the main monitor, no UI scaling
GeForce GTX 1060 6GB
Intel Core i5-4570 @3.20GHz
Windows 10 Pro 64-bit (10.0, build 18362)

Havent noticed any big change in performance.
Win+Shift+S captures things fine

[comp500]

@Azim That looks like a driver crash in texture uploading (deleted your comment as the game arguments contain your authentication token), not something related to Borderless Mining? I can't seem to replicate the crash on my NVIDIA GPU, it may be a driver issue or a problem with the other mods you're using.

[he3als]

Try re-installing/updating your graphics card drivers.

[Azim]

@Azim That looks like a driver crash in texture uploading (deleted your comment as the game arguments contain your authentication token), not something related to Borderless Mining? I can't seem to replicate the crash on my NVIDIA GPU, it may be a driver issue or a problem with the other mods you're using.

just tried updating graphics driver, but confirmed that the game doesnt crash when i remove the Borderless Mining mod
upd: even with updated driver it still crashes when mod is installed