Skip to content

Remove unused variables #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcbarton merged 2 commits into from
Oct 14, 2026
Merged

Remove unused variables #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4078a1c
Remove unused variables
mcbarton Oct 8, 2026
eda80d3
Try removing cast to void
mcbarton Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/xinspect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ namespace xcpp
std::string tagfile = it->at("tagfile");
std::string filename = tagfiles_dir + "/" + tagfile;
pugi::xml_document doc;
pugi::xml_parse_result result = doc.load_file(filename.c_str());
doc.load_file(filename.c_str());
class_member_predicate predicate{type_name, "function", method[2]};
auto node = doc.find_node(predicate);
if (!node.empty())
Expand Down Expand Up @@ -169,7 +169,7 @@ namespace xcpp
std::string tagfile = it->at("tagfile");
std::string filename = tagfiles_dir + "/" + tagfile;
pugi::xml_document doc;
pugi::xml_parse_result result = doc.load_file(filename.c_str());
doc.load_file(filename.c_str());
for (auto c : check)
{
node_predicate predicate{c, find_string};
Expand Down
4 changes: 1 addition & 3 deletions test/test_interpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ TEST_SUITE("xoptions")

bool exceptionThrown = false;
try {
bool isVerbose = (parser["--verbose"] == false);
(void)(parser["--verbose"] == false);
} catch (const std::exception& e) {
exceptionThrown = true;
}
Expand Down Expand Up @@ -840,7 +840,6 @@ TEST_SUITE("xsystem_apply")
TEST_SUITE("xmagics_contains"){
TEST_CASE("bad_status_cell") {
xcpp::xmagics_manager manager;
xcpp::xmagic_type magic = xcpp::xmagic_type::cell;
// manager.register_magic("my_magic", xcpp::xmagic_type::cell);

bool result = manager.contains("my_magic", xcpp::xmagic_type::cell);
Expand All @@ -849,7 +848,6 @@ TEST_SUITE("xmagics_contains"){

TEST_CASE("bad_status_line") {
xcpp::xmagics_manager manager;
xcpp::xmagic_type magic = xcpp::xmagic_type::line;
// manager.register_magic("my_magic", xcpp::xmagic_type::cell);

bool result = manager.contains("my_magic", xcpp::xmagic_type::line);
Expand Down
Loading