Repository navigation
Make DSD (DSF format) conditional on taglib support - #205
Open
tmzullinger wants to merge 1 commit into
Open
tmzullinger wants to merge 1 commit into
tmzullinger wants to merge 1 commit into
Conversation
The functions required by 832df65 (Add DSD (DSF format) support (complexlogic#178), 2026-03-22) are present only in taglib >= 2.0, with `TagLib::DSF::File` added in taglib commit 39d1d682 (DSD Stream File (DSF) support, 2023-09-25). Rather than increase the minimum taglib support, make DSD/DSF support conditional as is done for Matroska support. A downside of using the `TAGLIB_WITH_DSF` define is that it was added in taglib-2.1, commit ee1931b8 (Compile time configuration of supported formats (#1262), 2025-02-02), while `TagLib::DSF::File` was added in taglib-2.0 (in the commit noted above). To avoid this, also check for `TAGLIB_MAJOR_VERSION > 1`.
Author
|
I ran into this while building 3.8 for a host which had This could use only I tested on Fedora 44 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions required by 832df65 (Add DSD (DSF format) support (#178), 2026-03-22) are present only in taglib >= 2.0, with
TagLib::DSF::Fileadded in taglib commit 39d1d682 (DSD Stream File (DSF) support, 2023-09-25).Rather than increase the minimum taglib support, make DSD/DSF support conditional as is done for Matroska support.
A downside of using the
TAGLIB_WITH_DSFdefine is that it was added in taglib-2.1, commit ee1931b8 (Compile time configuration of supported formats (#1262), 2025-02-02), whileTagLib::DSF::Filewas added in taglib-2.0 (in the commit noted above).To avoid this, also check for
TAGLIB_MAJOR_VERSION > 1.