Repository navigation
Conversation
…cil-add-il-bits-to-bid
…s-inclusivity-check
…s-inclusivity-check
# Conflicts: # beacon_node/beacon_chain/src/block_production/gloas.rs # beacon_node/lighthouse_network/src/service/mod.rs # consensus/types/src/execution/execution_payload_bid.rs # consensus/types/src/execution/signed_execution_payload_bid.rs
…s-inclusivity-check
conache
force-pushed
the
focil-add-il-bits-to-bid
branch
from
October 7, 2026 12:51
1547fdf to
5769b3e
Compare
Owner
Author
|
Closing in favor of sigp#10263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the FOCIL implementation. This PR adds the inclusivity check for
bid.inclusion_list_bitson theexecution_payload_bidtopic (per spec).Proposed Changes
GossipVerifiedPayloadBid::newand satisfies the following rule (spec reference):verify_bid_inclusion_list_bitshelper, next to the existing checks the gossip and direct verifiers already share, with the bit comparison extracted from the inclusion list store into a pure functionPayloadBidError::InclusionListBitsNotInclusive, mapped toMessageAcceptance::Ignorein the network processorAdditional Info
verify_direct_bidand never reach the gossip verifier.verify_bid_inclusion_list_bitshelper on the block production path. Both PRs add this helper, so whichever merges first carries it and the subsequent PR should rebase on itpayload_bid_verification/tests.rstests pass withFORK_NAMEset to eithergloasorheze