Skip to content

lemur::align_harmony causes an error with recent versions of harmony #29

Description

@wolfganghuber

Reproducible example: see https://github.com/Bioconductor/CSAMA-labs/tree/devel/multicond-scRNA-lemur code chunk "align-lemur-model".

fit2 <- lemur(sce, design = ~ stim, n_embedding = 30, verbose = FALSE)
fit2 <- align_harmony(fit2, verbose = FALSE)

Error in check_legacy_args():
! Argument max.iter is unhandled. Please refer to the documentation for the valid harmony options!

Suggestions:

1.) preferentially: bug fix in the Bioconductor release of lemur, in time for CSAMA, second-best: a fix within the above lab qmd lab itself
2.) fix for next Bioconductor release, incl unit & integration test to pick up such problems automatically in the future

Thank you and kind regards
Wolfgang

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions