feat(datasets): declare, register and describe the queryable datasets - #3321
Draft
aleksdotbar wants to merge 3 commits into
Draft
aleksdotbar wants to merge 3 commits into
aleksdotbar wants to merge 3 commits into
Conversation
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (69)
Comment |
cyberantonz
approved these changes
Sep 8, 2026
Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
aleksdotbar
force-pushed
the
feat/datasets
branch
from
September 8, 2026 08:41
738936e to
236c3ec
Compare
Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
* feat(analytics): answer dataset questions through POST /v1/query Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar> * docs(query): clarify requirements and design Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar> --------- Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar>
aleksdotbar
marked this pull request as draft
September 14, 2026 04:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. Chart builders lack a reusable description of available data, so new query combinations depend on individual metric definitions and warehouse knowledge.
What changed. Adds dataset declarations, schema-snapshot validation, an embedded registry, and admin-only discovery. Each dataset defines its row identity and queryable fields alongside its model, tests, and documentation; shared preparation applies content deduplication for datasets and metric evidence.
Shipped definitions. Declarations are embedded with the service to keep changes release-controlled; runtime editing remains a separate extension. Snapshot validation does not verify a running warehouse's schema.
Coverage. Two datasets:
git_commitsandgit_file_changes, each with declared row identity and dbt uniqueness checks.Out of scope. Query execution is #3187. Tenant-defined datasets, approval workflows, and access policies remain planned in the design.
Verified. Documentation structure, TOCs, IDs, and links checked. Application checks were not rerun for the documentation update. Stand integration tests and the additional-context image build remain unverified.