Fix build with debug logging disabled - #802
Merged
Merged
Conversation
When debug-level log messages weren't enabled at compile-time, we can't look at `bwrap_is_debugging`, because it doesn't exist. Fixes: fd73997 "Add a mechanism to enable debug() at compile-time" Signed-off-by: Simon McVittie <smcv@collabora.com>
Instead of the intended `debug_logging` option (which is about debug-level log messages), the build-system switch was using Meson's built-in `debug` option (which is about emitting debug symbols for gdb). Fixes: fd73997 "Add a mechanism to enable debug() at compile-time" Signed-off-by: Simon McVittie <smcv@collabora.com>
swick
approved these changes
Sep 21, 2026
Collaborator
Author
|
I'll aim to get this released tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils: Fix the build with debugging disabled
When debug-level log messages weren't enabled at compile-time, we
can't look at
bwrap_is_debugging, because it doesn't exist.Fixes: fd73997 "Add a mechanism to enable debug() at compile-time"
build: Fix enablement of debug logging
Instead of the intended
debug_loggingoption (which is aboutdebug-level log messages), the build-system switch was using Meson's
built-in
debugoption (which is about emitting debug symbols for gdb).Fixes: fd73997 "Add a mechanism to enable debug() at compile-time"
cc @cgwalters @alexlarsson @swick
I'd like to get a 0.13.0 release out with #756 included, but this is a blocker for that.