docs: Edit and cleanup pass - #249
Open
crandmck wants to merge 5 commits into
Open
Conversation
Switches the GitHub-only content divs to class="github-only" (already
defined in opensource.contentauth.org's custom.css) instead of the
style={{display: 'none'}} JSX trick, which only works because it's
invalid CSS on GitHub. The class-based approach is plain HTML and
renders correctly everywhere.
crandmck
marked this pull request as ready for review
July 29, 2026 20:36
tmathern
approved these changes
Jul 29, 2026
| - The application controls its own write pipeline (e.g., a video transcoder or streaming ingest service) and wants to hash the asset during its own write pass rather than having the SDK re-read the finished file. | ||
| - The application needs to receive the raw signed manifest bytes and decide where and how to append them as a new chunk, rather than letting the SDK write to a destination path. | ||
| - The asset is being produced incrementally, so the application can pass the stream to `update_hash_from_stream()` at the right moment, then call `sign_embeddable()` to get the manifest without a second full read. | ||
| - The application produces the asset incrementally, so it can pass the stream to `update_hash_from_stream()` at the right moment, then call `sign_embeddable()` to get the manifest without a second full read. |
Collaborator
There was a problem hiding this comment.
Technically the SDK still produces the asset, the SDK is used by an application... I think the previous wording was more correct.
Contributor
Author
There was a problem hiding this comment.
IIUC, the action originates in the application, which then uses the SDK to produce the asset.
I changed it to "Using the SDK, the application produces the asset incrementally..."
Active voice is better in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-onlyCSS class instead of inlinedisplay:nonestyle to hide content in Docusaurus but still display in the GitHub web interface.