Completion complete - #121
Draft
cafalchio wants to merge 4 commits into
Draft
Conversation
cafalchio
force-pushed
the
completion_complete
branch
from
September 3, 2026 21:22
c424ce4 to
a34675f
Compare
lucarlig
requested changes
Sep 4, 2026
lucarlig
left a comment
lucarlig
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes: completion routing uses the wrong table, rewrites the wrong field, and is not advertised through discovery; please also enable a positive dataplane-only test.
| use super::McpService; | ||
|
|
||
| #[allow(clippy::unused_async)] | ||
| pub(super) async fn complete( |
Contributor
There was a problem hiding this comment.
server/discover currently advertises no completions capability, so capability-aware clients will never invoke this handler.
Contributor
Author
There was a problem hiding this comment.
I think this needs to be addressed on the discover.
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: cafalchio <mcafalchio@gmail.com>
Signed-off-by: Matheus <mcafalchio@gmail.com>
Signed-off-by: Matheus <mcafalchio@gmail.com>
cafalchio
force-pushed
the
completion_complete
branch
from
September 4, 2026 22:06
a34675f to
39b5e8a
Compare
Contributor
Author
|
@lucarlig I will keep it in draft until I test it. |
cafalchio
marked this pull request as draft
September 6, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for completions.
Conformance test is passing.
Completion tests are still marked are ignored as they are dependent on list_prompt and list_resources.