fix: use gateway-supplied MCP endpoint URL instead of window.location.origin - #107
Open
marekdano wants to merge 1 commit into
Open
fix: use gateway-supplied MCP endpoint URL instead of window.location.origin#107marekdano wants to merge 1 commit into
marekdano wants to merge 1 commit into
Conversation
….origin Signed-off-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IBM/mcp-context-forge#6632
Depends on IBM/mcp-context-forge#6656 — please don't merge this before that backend PR lands.
VirtualServer.urlonly exists in gateway responses once #6656 ships; until then this PR is a no-op and silently keeps today'swindow.location.originfallback behavior.Summary
Flagged in review on #101:
Same class of bug as the OAuth
redirect_urifix in #101: the web UI's own origin isn't necessarily where the gateway serves its endpoints in a split deployment. IBM/mcp-context-forge#6656 adds aurlfield toServerRead, computed server-side from the gateway's ownAPP_DOMAIN(the same base URL OAuth'sredirect_uridefault already uses). This PR switches the frontend to use it.Changes
src/types/server.ts: addurl?: stringtoVirtualServer.src/components/gateways/utils.ts:getVirtualServerEndpointnow takes the server object and prefersserver.urlover constructing fromwindow.location.origin, which remains only as a fallback for gateways older than theurlfield.src/components/gateways/VirtualServerDetailsPanel.tsx: updated the one call site.utils.test.tscovers theurl-preferred path and both fallback cases.