Repository navigation
Conversation
Gossip, getVersion, and solana --version all read this Cargo version. Co-authored-by: Cursor <cursoragent@cursor.com>
Gossip, getVersion, and solana --version all read this version. The cookie release number rides in the client id, because Agave's prerelease tag cannot store it. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Superseded by the Cookie 4.1.3 pull request. The version is a normal 4.1.3 patch, and the client id is Cookie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4.1.2-cookie.1.solana --version,getVersion, and gossip read that version, so all three show4.1.2-cookie.1.4.1.2-cookie.1cannot be packed asalpha,beta, orrc. The version numbers stay stable4.1.2on the wire. Thecookie.1release number rides in the client id.4.1.2. A node on this release shows4.1.2-cookie.1.Test plan
cargo test -p solana-version --features agave-unstable-api --lib(the Cargo version string matches what gossip prints, and4.1.2-cookie.1roundtrips)solana --versionstarts with4.1.2-cookie.1agave-validator --versionand a node'sgetVersionshow the same4.1.2-cookie.1