Repository navigation
Remove energy spectra for TAC cut by default - #221
Conversation
|
Is there any way we can have this appear, once both energy and TAC calibration module are run, no matter their order? |
|
Is the standard to do TAC before energy? |
|
I'm marking this as a draft so I can add the automatic checker as to whether or not the energy calibration is run first. Since I think we want this ExpoPlotSpectrum panel showing the before/after spectrum for the TAC cut if the energy calibration is running first. Right @NicoleRodriguezCavero ? |
cd41f5c to
d88e6b3
Compare
|
Okay, now in the TACCalibration Module, I check whether or not the energy calibration has run, and therefore whether it makes sense to show a spectra. If the TAC Cal comes first, we only get a spectra after the ECal. If the ECal comes first, we get a spectra after the ECal, and then a second spectra after the TACCal. I think this provide the right level of flexibility for different users. |
fhagemann
left a comment
There was a problem hiding this comment.
I like the way it is now: removing the expo plot if energy have not been calibrated, but keeping the current behavior if they have been :)




There is a tab in the Nuclearizer GUI for an energy spectra intended to be used before and after the TAC cut; however, the standard operation is to run the TACCalibration module before the EnergyCalibration module, so these spectra are empty.
In this PR, I've added a boolean to chose whether or not to have this additional spectra tab in the Nuclearizer GUI. Right now I have this hardcoded in the module construct, but I can be more clever about have this option accessible if people see a use-case. I think people are only going to want to use this plotting option when doing non-standard things and it's not clear how often that would be.
I did start to explore an option to only make this TAC Cut Spectra appear in the GUI if the EnergyCalibration module comes before the TAC Calibration module by iterating through the active modules in MSupervisor. So that's a possibility, but I erred on the side of simplicity today.