Resource directory cleanup

[ckierans]

Cleaning up the resource directory before releasing v1.0.0. I believe I removed all of the COSI Balloon and NCT files.

I kept the calibration/COSI_SingleDet directory for now, though I'm not sure it's much use to anyone these days.

There were a resource/calibration directory and a resource/dee directory. The files within the dee directory are mostly dummy files that Parshad originally used to get the SingleDet branch of the dee working. I moved these to the calibration/COSI_SingleDet directory to have those older files live there.

The files needed to run the current dee are found in the calibration/COSISMEX directory.

There was also the ShieldEnergyCorrection_v2.csv file from Valentina in the dee directory, and I moved that to a new calibration/ACS directory for all shield calibration files.

And I moved Parshad's deadtime parameter file to the resource/calibration/COSISMEX directory.

Let me know if you have any comments on the re-org.

[fhagemann]

Thanks for tackling this!

I personally might want to keep the dee folder though instead of COSI_SingleDet, because now COSI_SingleDet could confuse people looking for the things we put in COSISMEX/unit (the "real" calibration files).

Another thing to think about: where would I put dummy files for COSISMEX right now, e.g. a dummy depth spline or coefficients file to use before we have the final data file? Previously, I would have also put them in resource/dee, but this folder does not exist anymore. And I'm not sure I want dummy files in COSISMEX/payload.. 😅

But happy to be convinced otherwise!

[ckierans]

Okay, maybe I was overzealous. I'm happy to keep the dee directory as is, with the intention for that to be dummy files used for the DEE before we have the appropriate calibration files in hand.

I can undo the last commit.

[ckierans]

Should we rename or remove calibration/COSI_SingleDet to avoid confusion? These files were used during COSIfest last year to get the SingleDet branch of the DEE running for the first time. Should we keep these for any reason? Are they still of use to people?

[fhagemann]

Can we rename this to calibration/dee or back to dee, if the main purpose for having these dummy files is to run stuff through the DEE (that requires to pass some sort of files, but you might be fine with just a dummy file for the detectors if you only care about the shields for example)?

[fhagemann]

Maybe we can ask people if the meeting today, who's actually using this and if they have preferences.

[fhagemann]

But also, most of the files in the current calibration/COSI_SingleDet are files for the old DEE, so a lot of them could go.

[fhagemann]

If we're removing the old DEE files in this PR, we might as well use this PR to remove the old DEE modules (issue #170)

[ckierans]

I've removed the modules identified in Issue #170 , I've removed the calibration/COSI_SingleDet files that were only used as dummy files during COSIfest last year, and I've also removed the obsolete files in the apps directory.

[ckierans]

Waiting for a confirmation in slack that no one is using the COSI_SingleDet files anymore before merging this.

[fhagemann]

Tests are failing because, when deleting files, it cannot trace the code coverage.
If you want to make them pass again, go to Actions at the top bar, then Management > Caches, and manually delete all the ccache-Linux that has develop/em in its name. Then, restart the failed test.
Let me do this for this PR.

[ckierans]

I was just starting to look into the failing tests. Thanks @fhagemann !

[fhagemann]

One easy way to fix this would be to set the fail_ci_if_error flag to false, so that the automated tests really only fail if something was wrong with the code, rather than uploading the code coverage report to GitHub:

nuclearizer/.github/workflows/tests.yaml

Lines 171 to 176 in 37b471a

	- name: Upload Report to Codecov
	uses: codecov/codecov-action@v5
	with:
	token: ${{ secrets.CODECOV_TOKEN }}
	files: ./coverage.xml
	fail_ci_if_error: true

[ckierans]

Okay, Parshad and Valentina confirmed they're not using files in COSI_SingleDet, so those are gone.

@zoglauer do you want to take a glance at the things i've removed to make sure all is good before we merge?