Repository navigation
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update for PR #199, that was closed because of conflicts with the master branch.
This PR modifies the following files:
GUI configuration to read the calibration file:
I added the ability in MReadOutElementVoxel3D to also map the detector/crystal ID with the detector and crystal ID listed in the calibration file:
new DEE submodule (Shield Readout) to convert from energy to ADC the shield hits:
A new file (energy to ADC calibration parameters) is added in resource/dee/ShieldEnergyCalibration_NRL.csv
Changes from PR #199:
On this comment on include/MReadOutElementVoxel3D.h:
using bool without virtual in
bool operator<(const MReadOutElementVoxel3D& R) const;is correct, because it only needs to order between two MReadOutElementVoxel3D objects, while
virtual bool operator==(const MReadOutElement& R) const;should be able to compare any readout element from the derived class.