Repository navigation
CHG: Handling of comments in depth calibration files - #234
Merged
fhagemann merged 1 commit intoOct 7, 2026
Merged
Conversation
Relevant information is put in lines starting with three ### We should also allow for "regular" comments starting with single #
ckierans
approved these changes
Oct 7, 2026
Collaborator
|
Nice easy convention. I like it. Once the checks have passed, feel free to merge. |
Collaborator
|
The code looks OK. |
Author
|
Thanks for the swift responses! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, comments in the depth spline files are used to pass information on DetID etc.
These comments should always start with three
###as denoted in their comments:Comments in the depth splines file (we use this to pass the Detector ID, especially for files with multiple splines):
nuclearizer/src/MModuleDepthCalibration.cxx
Lines 736 to 739 in 3245f21
Comments for the depth coefficients file (we use this to pass information about at which energy the timing resolution is quoted):
nuclearizer/src/MModuleDepthCalibration.cxx
Lines 650 to 653 in 3245f21
The way the
nuclearizercode operates right now is that is parses EVERY line starting with#as a comment carrying that information. This does not allow us to put any other comments in the files, except for adding more tokens to these files.Following the convention that will also be used in the charge trapping module in #184, I am proposing to explicitly search for
###for those comments carrying information, and to allow for single-#comments that will just be ignored.