Repository navigation
Conversation
The current code was assuming that the ASIC polarities are sorted by Detector ID, but they are actually sorted by DIB ID in the JSON config.
fhagemann
marked this pull request as draft
October 12, 2026 00:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #229:
This one was a hard one to debug:
When assigning strip to HV or LV side, the nuclearizer code checks for ASIC polarity in the JSON config (if it exists).
The current implementation was fault in assuming that the ASIC polarities where sorted by detector ID, whereas they are actually sorted by DIB ID in the JSON config.
As the FM payload has a polarity flip in Q0L1 (Detector ID 1), which is DIB ID 9, the current code was seeing a polarity for Q0L1 (DIB 9), but actually applying it to Q2L1 (Detector ID 9), which messed up the HV/LV strip assignment for those two detectors. This should be fixed now.
Marking this as draft, because @robin4730 is running a lot of energy calibrations (that would be flipping HV and LV sides for Detectors Q0L1 and Q2L1), and we want to make sure we make this update once we have either corrected or deleted every "faulty" ecal file generated so far.