Skip to content

chore(deps): update dev dependencies with oxfmt, knip and axe-core fixes KIT-282 - #8771

Closed
alexprudhomme wants to merge 4 commits into
mainfrom
KIT-282-renovate-8521-dev-deps
Closed

alexprudhomme wants to merge 4 commits into
mainfrom
KIT-282-renovate-8521-dev-deps

Conversation

@alexprudhomme

@alexprudhomme alexprudhomme commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Jira: KIT-282

Supersedes #8521. That PR keeps the Renovate dev-dependency bumps (658d73b95) as-is, and this branch adds the fixes its failing checks need. Merging this one lets #8521 be closed.

Changes

  • Renovate bumps (658d73b95, unchanged): oxfmt 0.74, oxlint 1.89, knip 6.42.1, turbo 2.11.9, Storybook 10.6.3, axe-core 4.14.0, and the rest of the dev deps.
  • style(atomic,thermidor): apply oxfmt 0.74 formatting: output of pnpm run lint:fix:oxfmt on the 15 files that oxfmt --check flags with the new version. Formatting only, nothing changes at runtime, so no changeset.
  • chore(deps): adapt knip config to knip 6.42 (knip.js only):
    • vite: {config: []} no longer keeps vite.config.js as an entry, so the config is listed as an entry in the commerce-hybrid, commerce-vite and search-vite Atomic samples.
    • Ignores the create-ui binary in packages/create-ui (scripts/test-packed-bin.mjs runs the packed tarball's bin).
    • Moves size-limit from ignoreBinaries to ignoreDependencies in the root workspace: knip now reports require.resolve('size-limit/package.json') in scripts/size-limit.mjs as an unlisted dependency.
  • chore(deps): hold axe-core at 4.13.0: puts @coveo/atomic-a11y back on axe-core 4.13.0 and runs pnpm dedupe. Only the axe-core lines change in the lockfile.

Why the axe-core hold

axe-core 4.14 removes the experimental tag from label-content-name-mismatch (WCAG 2.5.3 Label in Name), so the rule now runs by default. On #8521 every Storybook test passes, but the a11y gate fails on the facet-header clear button (atomic-facet, numeric-, rating-, rating-range-, color-, timeframe-facet and atomic-breadbox stories). Its visible text is "Clear filter", but its aria-label is "Clear {{count}} filter for the {{label}} facet", so the visible text isn't part of the accessible name.

This is an existing a11y issue in Atomic that the new axe version detects. The hold is a stopgap.

Follow-up (not in this PR)

Fix WCAG 2.5.3 in the facet-header clear button (packages/atomic/src/components/common/facets/facet-header/facet-header.ts) so the accessible name starts with the visible text. For example, reword clear-filters-for-facet to something like "Clear filter: {{label}} facet ({{count}})", or drop the aria-label and add visually hidden context after the visible text. This changes a public Atomic string in every locale, and needs a changeset, an a11y review of the wording, updated specs and snapshots, and probably an OpenACR refresh. Once it lands, axe-core can move to 4.14.

Verification (local)

  • pnpm install --frozen-lockfile passes.
  • pnpm run lint:check passes (5/5 tasks).
  • pnpm exec knip --exclude catalog exits 0 after a full build, with configuration hints only.
  • vitest run --project=storybook on atomic-facet.new.stories.tsx and atomic-breadbox.new.stories.tsx: 10/10 pass, with no a11y violations (axe-core 4.13.0).

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b9104a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svcsnykcoveo

svcsnykcoveo commented Oct 27, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026

Copy link
Copy Markdown
@coveo/atomic

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/atomic@8771

@coveo/atomic-hosted-page

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/atomic-hosted-page@8771

@coveo/atomic-legacy

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/atomic-legacy@8771

@coveo/atomic-react

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/atomic-react@8771

@coveo/auth

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/auth@8771

@coveo/bueno

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/bueno@8771

coveo.analytics

npm i https://pkg.pr.new/coveo/ui-kit/coveo.analytics@8771

@coveo/create-atomic

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-atomic@8771

@coveo/create-atomic-component

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-atomic-component@8771

@coveo/create-atomic-component-project

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-atomic-component-project@8771

@coveo/create-atomic-result-component

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-atomic-result-component@8771

@coveo/create-atomic-rollup-plugin

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-atomic-rollup-plugin@8771

@coveo/create-ui

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/create-ui@8771

@coveo/headless

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/headless@8771

@coveo/headless-react

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/headless-react@8771

@coveo/quantic

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/quantic@8771

@coveo/relay

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/relay@8771

@coveo/shopify

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/shopify@8771

@coveo/thermidor

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/thermidor@8771

@coveo/atomic-angular

npm i https://pkg.pr.new/coveo/ui-kit/@coveo/atomic-angular@8771

commit: b9104a3

@chromatic-com

chromatic-com Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 472 tests unchanged
🟢 UI Review: 472 stories published -- no changes
Storybook icon Storybook Publish: 472 stories published

@github-actions

Copy link
Copy Markdown
Contributor

🔗 Scratch Orgs ready to test this PR:

@alexprudhomme

Copy link
Copy Markdown
Contributor Author

Superseded: these 3 fix commits are now pushed on top of #8521 (renovate/dev) instead of a separate PR.

This branch was successfully deployed

1 active and 1 inactive deployments
PR Artifacts — b9104a33 Deployed Oct 27, 2026 by alexprudhomme via Merge Quantic Playwright reports #20527
pr-workflows — b9104a33 Deployed Oct 27, 2026 by alexprudhomme via label #10115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants