Repository navigation
test(conformance): run the TypeScript conformance suites from their own workspace - #3
Closed
louis-bompart wants to merge 1 commit into
Closed
louis-bompart wants to merge 1 commit into
louis-bompart wants to merge 1 commit into
Conversation
…wn workspace Move the conformance runner out of @a2ui/web_core into a private workspace, @a2ui/conformance (typescript/conformance), that depends on @a2ui/web_core and @a2ui/catalog-basic. The runner checks the TypeScript SDK as a whole, so neither package's tests depend on the other any more. - web_core drops its test:conformance target and the wireit edge to catalogs/basic:build that loaded the v1 basic catalog's build. - The runner and its node resolution handler import the SDK through public entry points instead of ../../dist/src paths. - Case outcomes are unchanged: 561 passed, 654 skipped, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TypeScript conformance runner lived in
@a2ui/web_core(tests/conformance/). It runs the shared YAML suites underconformance/and, for every v1.0 case, uses the v1 basic catalog. Since coveord/a2ui#2 moved that catalog to@a2ui/catalog-basic, which depends onweb_core,web_core'stest:conformancehad to load the other package's build by relative path through a wireit edge.The runner checks the TypeScript SDK as a whole, not
web_corealone. This PR gives it a workspace of its own that depends on both packages, which removes the edge.What changes
@a2ui/conformance(typescript/conformance), not published, with the canonicalbuild,lint,lint:fix,test,formatandformat:checktargets.tests/conformance_test.mjs: the runner, moved fromweb_core/tests/conformance/.src/node_resolution.ts: thecore/node_resolution.yamlhandler, moved fromweb_core/tests/conformance/node-resolution.ts.@a2ui/web_core/v1_0,/semver,/v0_8/basic_catalog,/v0_9/basic_catalog,@a2ui/catalog-basic/v1) instead of../../dist/src/...paths. Every symbol they use was already public.@a2ui/web_coredrops itstest:conformancetarget and the wireit dependency on../../catalogs/basic:build.yarn testno longer runs the suites;yarn workspace @a2ui/conformance testdoes. The timing cases stay inweb_core'stest:timing.web_core's README andAGENTS.mdpoint to the new workspace.No published API changes, so no CHANGELOG entry.
CI
ci-renderersalready runstestin every workspace undertypescript/**, so the new workspace runs there with no workflow change.Verification
yarn workspace @a2ui/conformance test: 561 passed, 654 skipped, 0 failed. The previous runner on feat(catalogs)!: extract the v1 basic catalog into @a2ui/catalog-basic #2's branch gives the same outcome for every case.yarn workspace @a2ui/web_core test: 978 passed.lintandformat:checkpass for the new workspace;typescript/scripts/workspace.test.mjspasses.This PR is stacked on #2 and targets its branch, so the diff shows only this change.
🤖 Generated with Claude Code