Skip to content

fix: preserve root cause of OAuth Axios errors - #97

Merged
boly38 merged 1 commit into
creharmony:mainfrom
cawIgor:fix/96-handle-oauth-axios-errors
Oct 18, 2026
Merged

boly38 merged 1 commit into
creharmony:mainfrom
cawIgor:fix/96-handle-oauth-axios-errors

Conversation

@cawIgor

@cawIgor cawIgor commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve the existing rejection payload for OAuth HTTP errors
  • handle Axios/network errors that do not include a response
  • retain the original error as cause and expose its code and status when available
  • add regression tests for HTTP and network error handling

Fixes #96

Validation

  • npm test
  • targeted OAuth error tests

@hound hound Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

unreachable
unreachable
Error: unreachable
    at CodePathState.popChoiceContext (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-state.js:444:23)
    at processCodePathToExit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:434:19)
    at CodePathAnalyzer.leaveNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:627:9)
    at Traverser.leave [as _leave] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:868:28)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:155:18)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:147:30)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:144:34)

@cawIgor
cawIgor force-pushed the fix/96-handle-oauth-axios-errors branch from ec012fe to 1d111b3 Compare October 18, 2026 15:49

@hound hound Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

unreachable
unreachable
Error: unreachable
    at CodePathState.popChoiceContext (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-state.js:444:23)
    at processCodePathToExit (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:434:19)
    at CodePathAnalyzer.leaveNode (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:627:9)
    at Traverser.leave [as _leave] (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/linter.js:868:28)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:155:18)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:147:30)
    at Traverser._traverse (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/util/traverser.js:144:34)

@boly38
boly38 merged commit d22a75a into creharmony:main Oct 18, 2026
2 checks passed
@boly38 boly38 self-assigned this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth2Service is not able to manage AxiosError

2 participants