Skip to content

feat: support dollar sign in grid cells - #597

Open
moidsufiyan wants to merge 1 commit into
crosshare-org:masterfrom
moidsufiyan:feat/support-dollar-grid-cell
Open

moidsufiyan wants to merge 1 commit into
crosshare-org:masterfrom
moidsufiyan:feat/support-dollar-grid-cell

Conversation

@moidsufiyan

Copy link
Copy Markdown

Summary

  • Add $ as a supported grid-cell character
  • Add $ to the virtual keyboard
  • Update Firestore validation
  • Add a regression test

Testing

  • publishRules.test.tsx: 6/6 passed
  • Typecheck: passed
  • ESLint on changed files: passed
  • Prettier: passed

Copilot AI balanced review requested due to automatic review settings October 2, 2026 18:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants