WIP: SW discipline updates - #1809
Open
jsandoval81 wants to merge 3 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe PR adds social-work discipline visibility to license and privilege cards. It adds adverse-action sorting, collapse controls, localized disclaimers, and responsive discipline history rendering to public licensing details. ChangesSocial Work Discipline
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Store
participant PublicLicensingDetail
participant Localization
participant DisciplineSection
Store->>PublicLicensingDetail: Read social-work mode and adverse actions
PublicLicensingDetail->>PublicLicensingDetail: Sort adverse actions
PublicLicensingDetail->>Localization: Resolve discipline disclaimer
PublicLicensingDetail->>DisciplineSection: Provide records and collapse state
DisciplineSection->>PublicLicensingDetail: Toggle collapse state
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webroot/src/components/PrivilegeCard/PrivilegeCard.ts`:
- Around line 229-231: Update the shouldShowDiscipline getter to preserve the
existing privilege-purchase and privilege-administrator visibility gates, adding
only the isAppModeSocialWork condition. Remove the broad !this.isPublicSearch
fallback so non-admin JCC and Cosmetology users retain their current behavior.
In `@webroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue`:
- Around line 104-129: Update the discipline-list markup around the v-for
records to use native table semantics, replacing the div-based header and rows
with a table, thead, and tbody; render column labels as scoped th elements and
values as td elements while preserving the existing responsive phone labels and
displayed values.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 08f568b9-8b5e-473c-a346-1051092bc956
📒 Files selected for processing (9)
webroot/src/components/LicenseCard/LicenseCard.tswebroot/src/components/LicenseCard/LicenseCard.vuewebroot/src/components/PrivilegeCard/PrivilegeCard.tswebroot/src/components/PrivilegeCard/PrivilegeCard.vuewebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.lesswebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.tswebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1770
Summary by CodeRabbit
New Features
Bug Fixes