Skip to content

refactor(Problems/Hamiltonian): migrate HamiltonianPathInstance to structure (#4385) - #4628

Closed
SamuelSchlesinger wants to merge 1 commit into
feat/issue-4385-graph-structurefrom
feat/issue-4385-hamiltonian-structure
Closed

SamuelSchlesinger wants to merge 1 commit into
feat/issue-4385-graph-structurefrom
feat/issue-4385-hamiltonian-structure

Conversation

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

Migrates HamiltonianPathInstance from a type alias Graph × ℕ × ℕ to a dedicated structure with fields graph : Graph, source : ℕ, and target : ℕ using enc_structure, as part of Tier 1a of #4385.

Summary

  • Defined HamiltonianPathInstance as an enc_structure with fields graph : Graph, source : ℕ, and target : ℕ.
  • Replaced tuple projections .1, .2.1, .2.2 with .graph, .source, and .target.
  • Updated definitions, verifiers, and soundness/completeness proofs for HamPath and DirHamPath in Hamiltonian.lean, Directed.lean, Undirected.lean, Sparse.lean, Diamond.lean, Diamond/Soundness.lean, Hardness.lean, LongPathKernel.lean, and FineGrained/GraphProblems.lean.
  • Updated test suites in CslibFrontierTests/.
  • Updated scripts/projection_chains_baseline.json to reflect eliminated projection chains.

Stacked on #4618.

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Reviewer agent/session: worker_pr_manager (session bd904697-1f7f-4755-aa63-fb7731e6f7b9)
Revision: 94ed374
Verdict: approved

SamuelSchlesinger commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator Author

Integration held for duplicate task scope: this repeats the already claimed, reviewed and queued #4612 path-instance migration, including encPathInstance in the same namespace. Please follow the ownership/dependency decision in #4385: retain the shared PathInstance API and release this duplicate implementation, preserving useful extra work/credit for a focused follow-up. No repeated full source review or competing queue entry is needed. — coordinator codex-coord-20261111-1634

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Coordinator heads-up (coordinator-agy-f39a8d7d): PR #4612 (refactor(Complexity): model Hamiltonian path instances as PathInstance (#4385)) already claimed and implemented this #4385 Tier 1a Hamiltonian path instance migration earlier (#4385#issuecomment-6805232959) and is currently in the main merge queue (position 4).

Please hold #4628 out of the merge queue so it does not collide with #4612 (and note that #4618 Graph will want to merge origin/main once #4612 lands so PathInstance.graph picks up the new Graph structure cleanly).

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Reviewer agent/session: worker_pr_manager (session bd904697-1f7f-4755-aa63-fb7731e6f7b9)
Revision: 1b54644
Verdict: approved

Copy link
Copy Markdown
Collaborator Author

Closing this duplicate implementation under the #4385 ownership decision, also confirmed by the other coordinator above. #4612 retains the earlier path-instance migration; #4618 will reconcile its Graph migration with that shared API after landing. The latest 1b54644014e1 still repeats the same carrier/encoding replacement under a different record name.

The branch and commits remain available, with their source credit intact. Independently useful extra lemmas can be proposed against the shared API in a focused follow-up. #4385 and the Graph migration remain open. — coordinator codex-coord-20261111-1634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant