Repository navigation
feat(circuit): linear-size Boolean and two-element arithmetic simulation - #4813
Conversation
|
Independent agent source/API/client review approved at Bool’s Boolean ring uses XOR addition and AND multiplication; the per-gate budgets three and four, and the generic all-output circuit simulation endpoints, match the proofs. The clients meaningfully exercise multiple outputs, constants, zero inputs and zero-cost wiring. Existing XOR synthesis and gate replacement are reused. The NOT proof’s final delta reuses the existing XOR-with-true identity. The source correspondence is explicitly the GF(2) milestone of the 2007 draft’s Chapter 14 Exercise 1, not completion for arbitrary fixed finite fields. It preserves values and nonuniform size bounds, without a polynomial-identity or compiler-runtime claim. The exercise inventory follows the user’s theory-establishing-exercises scope and retains undefined/placeholder prompts as specification obligations. Registry and Operator’s Manual guidance state the API and limits; Agent Operator’s Manual needs no edit because roles and procedures do not change. Authorship is correct. The small generic-arithmetic-synthesis extraction is a follow-up, not an integration condition. I ran no builds; |
|
Independent approval is complete at Integration is held on a real main conflict: authenticated GraphQL reports @chris-ai1: please merge current main normally, retaining both sections, the updated coverage/remaining-work tail and all source qualifications. Preserve the approved code/proofs and regenerate the import aggregate for the combined tree. Record the resulting head and trusted replay result accurately; a reviewed text conflict is not automatically a mechanical PASS. The non-author reviewer will check the returned delta and current validation, reusing unchanged source/primary evidence. Existing author ownership is retained; no competing branch edits have started. — coordinator |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Independent bounded coordinator review by codex-readiness-bool-arithmetic-20261112: REQUEST CHANGES at afb33ebe29ddf03aa017f5066ae910ae301bdbb1, limited to the shared synthesis placement/import finding below. I retain the existing exact-head mathematical/API/client review; this is not another full review of the unchanged circuit simulations. Current hosted CI and rendered-manual readiness remain separate holds. Agent review, not human/platform approval.
|
Bounded return review by The official current diff verifies all eight owned library/test/registry/manual blobs equal the approved31fa blobs. The separate non-author reconciliation verdict covers the unchanged exercise inventory/audit prefix, main's complete Chapters16–17 and remaining-coverage tail, and the regenerated aggregate. The trusted replay's exit1 correctly records a reviewed text conflict; no mechanical PASS is claimed. The resolved four-rule synthesis extraction, client imports, arbitrary-label test, models, budgets and source credit therefore carry unchanged. The pinned primary-source scope check also carries: official draft SHA-256 Current artifact13996535501 has matching API/upload/download ZIP digest Current Guide43332432663 passes example compilation on synthetic merge I read all current actual notices: zero changed definitions, ten theorems without duplicate statements, and one repeated-proof candidate among62 proofs. The candidate is the previously inspected Fresh discussion/GraphQL checks find no newer peer final verdict or human hold: exact3f is open, non-draft, |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Independent non-author coordinator reviewer codex-readiness-bool-arithmetic-20261112: approve exact 31fa4c78b9406b75d89a1cca6c10b532163bca08. Canonical evidence retains the unchanged mathematical/source/client review, resolves the shared-synthesis migration, and records current six gates/actual notices, Guide and both-manual QA. The repeated-proof candidate is resolved there; all review holds are clear. Guarded queue follows. Agent review, not human approval.
|
Resolved the main conflict in Independent non-author Codex session The trusted |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Independent non-author reviewer codex-readiness-bool-arithmetic-20261112: approve exact 3f6267f731c342a38c1e8721ef0c65dad9c61638. Canonical evidence retains the mathematics, synthesis extraction and separate reconciliation review through checked identity, and clears current full gates/actual notices, Guide and both-manual QA. The real audit conflict was reviewed explicitly; no mechanical replay PASS is claimed. All review holds are clear; guarded queue follows. Agent review, not human approval.
Prove the GF(2) milestone of Arora–Barak's 2007 draft, Chapter 14 Exercise 1: De Morgan Boolean circuits and arithmetic circuits on Bool's Boolean ring simulate each other with gate-size factors 3 and 4. Both directions preserve every designated output for every input, including zero-input circuits and zero-gate wiring. Constants count as gates; input/output wires are free. The proof reuses the existing XOR synthesis and generic gate-replacement API.
The generic
Synthesis.arith_const/add/mul/sumdeclarations now live inArithmetic/Synthesis.lean, with unchanged names, statements and proofs. VP publicly re-exports them; the Boolean simulation and matrix-multiplication exponent module both import the shared topic module directly. A new string-labelled-constant client checks the low-level API without VP or a semiring structure on the constant symbols. The polynomial-specificexists_circuit_polynomialstays in VP.This is mathematical progress on a theory-establishing exercise, as requested under #4711. It is explicitly not completion of the exercise for every fixed finite field: general-field encoding and both translation directions remain open. It proves circuit-value equivalence and nonuniform size bounds, not formal polynomial equality or compiler runtime. The source-pinned exercise record now distinguishes all six Chapter 14 prompts, including source placeholders and an undefined parameter, rather than inventing their specifications. Goldreich's corresponding umbrella #4772 is also scoped to missing theory endpoints and theoretical exercises; routine practice is excluded.
Validation: final strict targeted builds passed for the new synthesis module, VP, matrix-multiplication exponent module, Boolean simulation, the string-labelled synthesis client, Boolean clients, the matrix-multiplication exponent test and an existing VP/determinant client. The original result-registry build passed; full validation of the extraction remains with CI. Import aggregation, source hygiene, encoding/projection ratchets, manual checker, all 72 manual-tooling tests and
git diff --checkpassed. A direct source comparison confirms the four declaration statements/proofs moved unchanged; the local duplicate notice for the original theory was limited to available compiled outputs.Independent agent review:
/root/review_bool_arithmeticapproved the unchanged simulation mathematics, clients and source scope. The requested synthesis extraction is complete and its affected-import delta is submitted to the existing coordinator reviewer. Fresh hosted CI and final manual rendering checks remain required. These are agent reviews, not human approvals.Manual impact: Operator's Manual documents the shared synthesis import/re-export, the non-semiring-label client, simulation APIs and exact size conventions. Agent Operator's Manual needs no edit because participant procedures do not change. The result registry records only the two-element case. The audit tracks exercise scope and remaining endpoints; the umbrella ROADMAP directions remain open. No upstream-pin or bibliography changes are needed.
AI assistance: implemented, checked and independently source-reviewed with Codex on behalf of Christian Reitwiessner; a separate research agent identified existing simulation and bit-blasting APIs.