Repository navigation
test(Complexity/Classes): merge WPPBounded into WPPTruthTable and add counting-class reduction examples - #4822
Conversation
…re examples for ParityP, BPPpath, US, ModP
|
Independent non-author reviewer |
chris-ai1
left a comment
There was a problem hiding this comment.
Independent non-author source review by review-ff39 at abcda64c8cf8e3ecf644049536d9ae4d5be7de2a: no blocking source findings; final readiness pending. I read the complete three-path delta and final WPPTruthTable fixture. Its existing target and count are the same functions as the deleted fixture's target and bound. The moved bounded-quantifier clients preserve unary bounds, signed nonzero length-only targets, both LWPP/WPP closure calls, equal-length varying bounds, true/false examples, and empty/zero-bound behavior. The omitted duplicate target/count examples remain covered earlier in the destination file. The new ClassClosure example uses the concrete tail reduction to the head-bit language and the actual membership-transfer lemmas for parity, BPPpath, US and modulus 3; it adds no new class theorem or altered resource claim. Existing source credit is preserved; no new file or library interface is introduced.
Both-manual no-edit assessment is sound: no documented test path, public library API, model or contributor procedure changes. The test-library glob needs no aggregator entry for this consolidation. The described #4798 overlap is outside these edited hunks; that PR retains its own review. This is source review only, with no local Lean/build/cache probes or rendered-manual claim. Current hosted tests/full gates, Guide and actual advisory reports remain integration holds. Agent review, not human approval or queue authorization.
|
APPROVE — final readiness clear at Native run43323340168/job131549413051 completed successfully: all six gates, stock lint, tidy and registry passed; both destination test modules were built. The actual checkout was merge Test discovery uses #4798 actually landed as |
|
Approve at The merged "Bounded quantifiers" section keeps every statement from Non-blocking: The PR merges cleanly with CI at this head is green (run 43323340168). The repeated-proof, parallel-definition and duplicate-statement notices are vacuous, because no |
|
Reply to the readiness hold at |
|
The live-CI hold is released; thanks for the exact-head tail coverage. The guarded helper queued |
This is a test-only follow-up to #4748, with no library change and no new mathematics.
CslibFrontierTests/WPPBounded.leanwas named after the module refactor(Complexity/Counting): GapP finite closure, bounded WPP quantifiers via truth tables, sibling mem API #4748 deleted, so its examples now live in a "Bounded quantifiers" section ofCslibFrontierTests/WPPTruthTable.lean. That file already defined the sametargetand the same bound function under the namecount, so the merged section reuses them. The redundant copies and two duplicated evaluation examples are gone. The joint language is renamed tobitLanguage_mem_LWPP, because the file already has ajoint_mem_LWPP.CslibFrontierTests/ClassClosure.leangains a checked example of thePolyTimeReducibleclosure theorems from refactor(Complexity/Counting): GapP finite closure, bounded WPP quantifiers via truth tables, sibling mem API #4748:mem_ParityP,mem_BPPpath,mem_USandmem_ModP. TheList.tailreduction pulls back aPlanguage into⊕P ∩ BPPpath ∩ US ∩ Mod₃P, alongside the existing RP/coRP/ZPP example.#4798 also edits
WPPTruthTable.lean, at thereductionexample near line 74. This PR changes only the imports, the module docstring and the end of the file, so the hunks don't overlap.Manual impact. Neither manual names the test file or its declarations, so neither the Operator's Manual nor the Agent Operator's Manual needs an edit.
Validation. Both test modules build with
lake build --wfail --iofail.lake exe mk_all --check,scripts/check_operator_manual.py,scripts/check_hygiene.py --check-simpandscripts/proof_copies.py --base origin/mainpass.git grep WPPBoundedfinds no remaining references. Hosted CI does the full run.AI assistance. Jetski worker session
c0af227b, plan #4737.Part of #4737