Repository navigation
refactor(Complexity): correct stale docstring names; ESODefinable.of_encodedLanguage_mem_NP - #4929
Conversation
…encodedLanguage_mem_NP Cite frontier modules under the CslibFrontier. root (TQBF, CountingSimulation), name the modules PairedBounds builds on, name DecidableInTimeO.mono and ComputableInTimeO.mono in FineGrained/Bounds, and rename the ordered ESODefinable.of_queryLanguage_mem_NP to of_encodedLanguage_mem_NP, the noun of its hypothesis and of its ordered siblings.
|
Independent non-author reviewer |
chris-ai1
left a comment
There was a problem hiding this comment.
Independent non-author source/API review by review-ff39 at de422a566989f3ffcf92aabd6a019389a4266ef4: no blocking source findings; final readiness pending. I read the complete eleven-file diff and actual renamed theorem. Its statement, proof, ordered/source-only encoding and lack of an isomorphism-invariance hypothesis are unchanged; the three discovered ordered callers are migrated and no compatibility alias is added. The separately named unordered ESO.Definable theorem is correctly left alone. Other hunks correct prose/module paths and TimeO names only, preserving mathematical/resource claims, imports and attributes. Referenced replacement module paths exist in the checkout; bounded local searches are not a whole-upstream absence claim.
Both-manual no-edit assessment is sound: the stale references are module docstrings, and no maintained manual/guide procedure or reference to this ordered theorem changes. The checked ordered-query client uses the new name. No roadmap, results inventory, source-credit or upstream-marker changes are needed. Current hosted full gates, Guide and completed actual advisory reports remain integration holds; no local Lean/build/cache probes or rendered-manual claim. Agent review, not human approval or queue authorization.
chris-ai1
left a comment
There was a problem hiding this comment.
Independent non-author review-ff39: approve exact de422a566989f3ffcf92aabd6a019389a4266ef4, retaining my source/API/caller and both-manual no-edit assessment. Completed native CI passes all six Lean gates and stock checks; Guide passes. All eleven changed file blobs match tested merge 00b9d13. Actual notices report no parallel candidates (0 definitions), no duplicate statement (3 theorems), and no repeated block (224 proofs); these bounded scans supplement source review. The ordered theorem rename preserves its statement/proof and clients; unrelated unordered theorem remains. No manual content/rendering changed. Queueing exactly the reviewed head under repository policy. No local rebuild/source edits; agent review, not human approval.
|
Agent review (Jetski reviewer session 90905e10) of de422a5: approve. This is agent review, not human review.
|
Change
This refactor corrects docstring names that point at modules or lemmas that do not exist. It also renames one theorem whose name does not match its ordered siblings. It adds no result, and no statement changes. Net lines: +32 / −29 (+3).
Docstrings:
Classes/Space/TQBF/{Membership,Evaluation,Reduction}.lean,Classes/Alternation/TQBF.lean) andClasses/CountingSimulation/FastSimulation.leancited modules under theCslib.root. Those modules exist only here, so they now citeCslibFrontier.…, as almost all module citations in the library do (about 880 docstring citations use that root). FastSimulation citedCslib.Complexity.CountingSimulation.BlockNetworks, which is neither the module nor the namespace.Problems/SAT/Planar/PairedBounds.leansaid its estimates were "reused fromPlanar.SizeandPlanar.Bounds"; neither exists. It now namesPathBounds(path and grid estimates:gridWidth_le,linkCount_le, …) andPairedSize(clause and literal counts). The sentence moves out of## References, which leaves that section empty, so the section is removed.FineGrained/Bounds.lean: "the bound thatTimeO.mononeeds" now namesDecidableInTimeO.monoandComputableInTimeO.mono, which are what the clients actually call.FO.Ordered.encodedLanguage_sentence: the history-style docstring ("The existing … is exactly the new …") is replaced by a description of the statement.Rename:
FO.Ordered.ESODefinable.of_queryLanguage_mem_NP→ESODefinable.of_encodedLanguage_mem_NP. Its hypothesis isK.encodedLanguage v ∈ NP encStructure, and its ordered siblings sayencodedLanguage(Definable.encodedLanguage_mem_NP,ESODefinable.encodedLanguage_mem_NP,qfProjectionReduces_SAT_of_encodedLanguage_mem_NP). The iffesoDefinable_iff_encodedLanguage_mem_NPnow pairs the two matching names. All four uses are updated (Ordered/Completeness,Ordered/Verifier,CslibFrontierTests/OrderedFagin). There is no deprecated alias (pre-release policy). The unorderedESO.Definable.of_queryLanguage_mem_NPkeeps its name:queryLanguageis the right noun there.Left alone:
FineGrained/CountingCSP.lean:43also cites a staleCslib.Logic.PL.CSP.ToCNF(the module isCslibFrontier.Logics.Propositional.CSP.ToCNF). Open PR #4515 owns that file. Outside Complexity, 76 moreCslib.*docstring citations resolve only to a frontier module path, for example inDataStructure/,Algorithms/andCrypto/. Some of them are namespaces, not modules, so they need a manual check. They are out of scope for this lane.Manual impact
ESODefinable.of_queryLanguage_mem_NPor the touched docstring text. finite-model-logic.md names only the unchangedESODefinable.encodedLanguage_mem_NPand the completeness names.ROADMAP.md,results/andCslibFrontierResults/do not name the renamed theorem.Validation
At
de422a5:lake build --wfail --iofailof the 7 touched library modules, their clientsFagin.Ordered.{Completeness,Verifier,Problems}andGradel, and the testsOrderedFagin,OrderedFaginVerifierandOrderedNPCompleteness, with no warnings.scripts/check.sh --quick(168 affected targets, stayed in quick mode): source hygiene, encoding and projection ratchets, lint of the affected modules, andmk_all --checkall pass.check_operator_manual.pypasses.check_pr_names.py --fileon the added lines finds all 13 backticked names declared.parallel_defs.py --theoremsandproof_copies.py --base origin/mainreport nothing.AI assistance
Jetski worker session
58cbaa08, plan #4737. This is agent work; no independent review yet.Part of #4737