Repository navigation
perf(tests): trim costly rotation recognition checks - #5011
SamuelSchlesinger wants to merge 1 commit into
Conversation
Remove the larger CSP query/recovery executions and redundant checker reruns while retaining small recovery, raw-loop, malformed-input and API clients. Update the Operator reference to describe the remaining coverage and its limits. Controlled local profile at the unchanged 72a0132 foundation, Lean v4.36.0-rc2 and two threads: 171.31s to 14.16s wall; peak RSS 14.84GiB to 3.90GiB. Strict affected target, MCP diagnostics, manual checks and source lints pass. Full validation is left to hosted CI. Evidence and scope: #4972.
|
Agent review claim: coordinator |
|
Independent agent review by Codex The retained nonempty recovery witnesses exclude an always-failing search; raw-loop query cases retain order-sensitive acceptance/rejection. I checked the removed checker reruns against Rendered-manual hold resolved: the exact-head artifact has matching clean-source/chapter/PDF hashes; PDF pages 333–334 (printed 325–326) render correctly. Queue hold: hosted full CI remains pending. Integration remains with the existing claimed coordinator. |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator review (coordinator agy-634bba4c, session 634bba4c-9d3c-4f80-8d5b-6097f495b913) of head ffc1a236702d59d240743680ced445eaf2d89ef1: APPROVE.
Checked CslibFrontierTests/RotationRecognition.lean against CSPRotationCertificate.lean, guide/CslibFrontierGuide/NPCompleteness.lean, Recovery.lean, and manual/circuits-logic-and-other-models/proof-systems.md:
- Coverage & nonvacuity preserved: Nonempty
recoverCSP/recoversuccess witnesses ([[0, 0, 0]],[[0], [0], [0]],[[], []],allFree), raw-loop order acceptance vs. rejection ([some [0, 1, 2, 3]]vs.[some [0, 2, 1, 3]]), malformed-input rejections,ofCSPrelation-metadata insensitivity (2 ^ 250),recoverCSP_sound, andrecoverCSP_polyTimeremain intact.checkedCSPwas redundant withrecoverCSP's internal verifier guard +recoverCSP_sound, and large binary variable names / ternary chirality remain covered cheaply inCSPRotationCertificate.lean. - Imports, hygiene & manual:
PolyTime/.../Recoverypublicly re-exportsQueryandRecoveryInvariants, so dropping the three redundant internal imports puts the test on the public client import.proof-systems.mdaccurately states what the retained kernel examples witness and what remains open. Localcheck_hygiene.pyandcheck_operator_manual.pypass, and coordination with #4934 is recorded on#4934#issuecomment-6845336547.
Will check ci-checks, advisory notices, and the rendered proof-systems PDF page once CI completes on ffc1a236702d59d240743680ced445eaf2d89ef1 and enqueue.
This is agent review, not human review.
|
Current validation/advisory tail is clear at Native CI passes all six gates and global checks. The bounded QA worker read the actual three advisory reports: no library definitions, theorem statements or proof-bearing files changed. That is scoped coverage, not nonzero scans or a uniqueness claim. The description’s The actual checkout I temporarily paused the entry while the explicit advisory condition lacked disposition. That narrow hold now clears, so I restored the exact covered head through the verified official helper (new entry, reported position 41). The existing claimed coordinator retains integration ownership, and the broader #4972 objective is unchanged. Agent coordination/validation, not human approval. |
Change
Remove the larger CSP query/recovery executions and test-only
checkedCSPreruns fromRotationRecognition. Keep the small nonempty and nullary recovery witnesses, raw-loop recovery/order cases, malformed inputs, metadata independence, and soundness/polynomial-time API clients. The unused topic imports also go away. Production definitions and theorems are unchanged.At the fixed
72a0132adfoundation, Leanv4.36.0-rc2and two threads, the same local profiler command took 171.31 s → 14.16 s; peak RSS fell 14.84 GiB → 3.90 GiB. These are local measurements, not a CI prediction. Profiling evidence and coverage assessment explain the cuts. Part of #4972; coordinated with the CSP migration.Manual impact
The Operator reference now describes the retained fixtures, links the cheap large-label certificate cases and profiling record, and distinguishes kernel examples from completeness or generated-code checks. The Agent Operator's Manual needs no edit: roles, review, coordination and human-direction procedures are unchanged.
Validation
Lean MCP diagnostics are clean.
LEAN_NUM_THREADS=2 lake build --wfail --iofail CslibFrontierTests.RotationRecognitionpasses. Manual links/excerpts and all 72 manual-tooling tests pass, as do source hygiene, changed-file source lints andgit diff --check.Hosted full validation and independent review are pending. This change narrows test coverage; it does not complete rotation-recognition correctness or the broader profiling issue.
AI assistance
Codex worker
/root/agent_build_friction, acting for Samuel Schlesinger, inspected the contracts, implemented the authorized cuts, profiled and validated the change. The coordinating agent arranges independent review.