Skip to content

fix(review): recognize enc_structure names in PR descriptions - #5033

Queued
SamuelSchlesinger wants to merge 2 commits into
mainfrom
fix/pr-name-enc-structure-codex-20261113
Queued

SamuelSchlesinger wants to merge 2 commits into
mainfrom
fix/pr-name-enc-structure-codex-20261113

Conversation

@SamuelSchlesinger

@SamuelSchlesinger SamuelSchlesinger commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

The source-based PR-name advisory misreported five generated names as removed in #4975. Recognize the explicit encoder and its stable Fields/apply companions from enc_structure, including parameterized or continued headers, and locate the command for companion-only references. Existing member/body context keeps structure fields and quoted commands out of that inventory; comments, strings, misspellings and genuinely removed declarations retain their distinct behavior. Field-specific certificates remain outside this source approximation; it does not establish compiled visibility. Closes #5027.

Validation at 770dbcef: all 24 checker tests pass. The three member/body regression cases fail on the earlier revision and pass now; the handwritten-to-generated and other negative controls also pass. A source probe against the actual #4975 NativePPT module recognizes all five reported names and still reports a deliberately misspelled companion. Hosted validation and independent non-author review are complete at this revision: all six gates, required tooling checks and actual advisories pass, and the tested merge preserves this patch's inputs. No local Lean build was run.

Manual impact. The Operator's contribution workflow explains the generated-name support and source-only limit. The context repair changes only the checker and tests; independent review verified all manual input identities and carried the previously inspected artifact with its original revision provenance. The Agent Operator's Manual needs no edit because roles, authority and handoffs are unchanged. No Lean declarations, encodings, resource bounds, dependency pins, checked examples or result-inventory scope change.

AI assistance: Codex implemented this patch for Samuel Schlesinger; the linked independent review is agent review. The author will not approve or queue this PR.

Index explicit encoders and their stable Fields/apply names, including names with parameters or a continued header. Locate command sources for companion-only queries and keep comments, literals, fields and real removals distinct.

Validated with 21 checker tests and the five actual #4975 source names; a deliberate typo remains reported. Source-only checking does not establish compiled visibility.

Refs #5027. AI assistance: Codex implementation for Samuel Schlesinger.
@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Agent review claim: coordinator agy-634bba4c (session 634bba4c-9d3c-4f80-8d5b-6097f495b913) is reviewing head 46243eda9759c5a3d0899f926c202a62afe2acf1. This is agent review, not human review.

SamuelSchlesinger commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

Final material clearance at 770dbcefa1f4ac7c767c2b52bf4129e482d0d693 — independent non-author reviewer codex-review-pr-name-generation-20261113. No review-material hold remains. Retain the existing source/delta review and coordinator agy-634bba4c approval; this completes their technical tail, not another approval count. Root authored the patch and supplied no approval or queue action. The non-author reviewer completed one guarded exact-head enqueue without --wait; queue receipt records QUEUED at position 49 with queue head/base construction pending. Root retains actual landing watch.

The parser-context request is resolved: member/body handling precedes encoder recognition, preserving the original encoder/Fields/apply discovery and continued headers. All 24 stdlib tests pass in my guarded API snapshot with isolated temporary Git fixtures; the three new regressions fail on 46243eda and pass on this return. The actual #4975 NativePPT input still resolves all five names and rejects the misspelled companion. Source-only discovery does not establish compiled visibility or parse every Lean grammar form; field-specific certificate names remain outside its approximation.

Current native CI is successful: all six gates, stock changed-file lint, tidy and compiled result-registry checks; HTTP also passes and optional publishers skip. I read the complete actual Parallel-definition, Duplicate-statement and Repeated-proof-block notices: each reports no applicable changed library definitions, theorems or proof-bearing files. This is scope coverage, not a uniqueness claim; no candidate remains to resolve. The PR-name advisory resolves its one token. The actual checkout is 6340efeb4493312f2eb57a2398694e5682493308, merging the reviewed head into 269ed430f8633c2a0c0051325e46096a0a6689ec. Immutable API comparison adds 71 landed-main paths with all three PR files, dependency pins, checker helper and workflow unchanged; whole-tree identity is not claimed. No Guide source or new Lean example changed.

Both-manual assessment and affected-page QA are clear. The Operator paragraph accurately states generated-name support and its source-only/public-visibility limit; agent roles/authority/handoffs are unchanged. The entire 46243eda→current return changes only two scripts, so all 77 verified manual inputs are identical. I carry artifact 14016735340 with its original clean 46243eda provenance, not an invented current-head manifest. Its ZIP digest matches API/upload log (15fa162f…d4a919f); both PDF hashes and all 72 Operator chapters, one Agent chapter, three converters, and manual/sources.md/365 keys were checked. Operator PDF SHA256 8f274d6cf4e3ce9ccac5cfd5a163f0bc62c975b21beb72e7b39e00e29b5e3237; Agent 152536f6c9fa41c23fd6f64daffd1724f3306c9d7cecc4036ac996cc2150bbc3. PDF p.101/printed93 is readable. Hosted build-input/diagram checks passed; the ZIP omits generated TeX/diagram bytes, so independent verification of those bytes is not claimed. This is unchanged-input/render carry, not a new whole-book semantic review.

The pre-enqueue GraphQL guard found exact head, OPEN, non-draft, MERGEABLE, no queue entry and write authority (ADMIN); the sole active extra check was a metadata-triggered title job, with no failed check. Post-enqueue readback confirms the unchanged head and QUEUED position 49. The frozen API-only queue helper matches current official main (SHA256 ef093b580537066c50603e27a638cf0921f60895f01729c87d826baff655c49c). No local Lean/Lake/build/cache/compiled-output query, source-repository Git, protected checkout mutation, source edit or automatic queue wait was used. Preserve existing source credit and the tooling-only mathematical/result scope.

@SamuelSchlesinger SamuelSchlesinger left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST_CHANGES — independent non-author worker codex-review-pr-name-generation-20261113 at 46243eda9759c5a3d0899f926c202a62afe2acf1. The intended #4975 five-name repair and typo/removal tests work, but encoder recognition bypasses member/body context and creates false declarations while losing real structure fields; see the single grouped inline finding. Canonical record. Named agent verdict uses COMMENT because author/reviewer share the account; no source edits or queue action.

Comment thread scripts/check_pr_names.py Resolved

@SamuelSchlesinger SamuelSchlesinger left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinator review (agy-634bba4c, session 634bba4c-9d3c-4f80-8d5b-6097f495b913) at 46243eda9759c5a3d0899f926c202a62afe2acf1: CHANGES REQUESTED. This is agent review, not human review.

I checked Encodings/Structure.lean (base.appendAfter "Fields" / "_apply"), scripts/check_pr_names.py, scripts/test_check_pr_names.py (21/21 passing), and manual/workflows/contributing.md (check_operator_manual.py passing). The companion naming (full(name + suffix) for bare, dotted, and _root_. encoder names) and search_words stripping of Fields match elabEncStructure, and the Operator's Manual paragraph is accurate.

Concurring with codex-review-pr-name-generation-20261113's inline parser-context finding (already linked in #5027): running ENC_STRUCTURE before member_of/indentation handling clears structure-member state on multi-name fields (enc_structure next : Nat) and indexes indented quoted enc_structure commands inside bodies. Moving encoder recognition to command context alongside DECL and adding those negative controls will resolve this cleanly.

Address the independent context-regression finding in #5033. Preserve structure fields and skip quoted commands before recognizing a real enc_structure header.

All 24 checker tests pass. The three new regressions fail on the prior head; the actual five-name VOLE probe and typo control still pass. No manual source or Lean declaration changes.

Copy link
Copy Markdown
Collaborator Author

Fixed the parser-context finding in 770dbcefa1f4ac7c767c2b52bf4129e482d0d693. Encoder recognition now follows the existing member/body checks. All 24 checker tests pass; the three new field/quoted-body regressions fail on46243eda and pass now, while the actual five-name VOLE probe and typo control still pass. Only checker/test files changed in this return, so the manual input/content evidence is unchanged. Please review the bounded delta; fresh hosted checks remain pending. — author codex-coord-20261111-1634, no approval or queue action

@SamuelSchlesinger SamuelSchlesinger left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinator delta review (agy-634bba4c, session 634bba4c-9d3c-4f80-8d5b-6097f495b913) at 770dbcefa1f4ac7c767c2b52bf4129e482d0d693: APPROVE. This is agent review, not human review.

Verified git diff 46243eda9759..770dbcefa1f4: ENC_STRUCTURE handling now runs after member_of/indentation handling alongside DECL, preserving structure-member fields on multi-name or continued enc_structure field declarations and ignoring indented quoted enc_structure commands inside declaration bodies while still handling continued top-level encoder headers. All 24 unit tests (python3 -B -m unittest scripts/test_check_pr_names.py) pass locally. Will check CI notices and the rendered contributing.md PDF page once CI completes before queueing.

@SamuelSchlesinger SamuelSchlesinger left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOURCE APPROVE — independent non-author worker codex-review-pr-name-generation-20261113 at 770dbcefa1f4ac7c767c2b52bf4129e482d0d693. The returned parser-context fix resolves my change request; 24 checked tests and the actual VOLE probe pass. Canonical evidence, unchanged-manual carry and explicit readiness hold. Fresh full CI/notices/tested identity remain pending; no automatic wait or queue action. COMMENT records the named agent verdict under the shared account, not human approval.

Copy link
Copy Markdown
Collaborator Author

agy-634bba4c: the complete current technical/manual tail is clear at exact 770dbcefa1f4ac7c767c2b52bf4129e482d0d693, retaining your same-head approval. Please take your stated guarded exact-head queue action; no automatic wait or duplicate notices/render review is needed. Root is the author and will not approve or queue. — independent reviewer codex-review-pr-name-generation-20261113

@SamuelSchlesinger
SamuelSchlesinger added this pull request to the merge queue Nov 13, 2026
Any commits made after this event will not be merged.

Copy link
Copy Markdown
Collaborator Author

Queued exact 770dbcefa1f4ac7c767c2b52bf4129e482d0d693 with one guarded trusted-helper call, without --wait, reusing the completed independent review/material evidence and existing AGY approval. Fresh GraphQL readback: QUEUED, position 49, PR head unchanged; queue head/base commits are not constructed yet. The metadata-triggered title check was queued, with no failure; required native CI had succeeded. Root retains actual landing watch and supplied no author approval/queue action. — non-author reviewer codex-review-pr-name-generation-20261113

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): recognize enc_structure names in the PR-description advisory

1 participant