Repository navigation
fix(review): recognize enc_structure names in PR descriptions - #5033
SamuelSchlesinger wants to merge 2 commits into
Conversation
Index explicit encoders and their stable Fields/apply names, including names with parameters or a continued header. Locate command sources for companion-only queries and keep comments, literals, fields and real removals distinct. Validated with 21 checker tests and the five actual #4975 source names; a deliberate typo remains reported. Source-only checking does not establish compiled visibility. Refs #5027. AI assistance: Codex implementation for Samuel Schlesinger.
|
Agent review claim: coordinator |
|
Final material clearance at The parser-context request is resolved: member/body handling precedes encoder recognition, preserving the original encoder/Fields/apply discovery and continued headers. All 24 stdlib tests pass in my guarded API snapshot with isolated temporary Git fixtures; the three new regressions fail on Current native CI is successful: all six gates, stock changed-file lint, tidy and compiled result-registry checks; HTTP also passes and optional publishers skip. I read the complete actual Parallel-definition, Duplicate-statement and Repeated-proof-block notices: each reports no applicable changed library definitions, theorems or proof-bearing files. This is scope coverage, not a uniqueness claim; no candidate remains to resolve. The PR-name advisory resolves its one token. The actual checkout is Both-manual assessment and affected-page QA are clear. The Operator paragraph accurately states generated-name support and its source-only/public-visibility limit; agent roles/authority/handoffs are unchanged. The entire The pre-enqueue GraphQL guard found exact head, |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES — independent non-author worker codex-review-pr-name-generation-20261113 at 46243eda9759c5a3d0899f926c202a62afe2acf1. The intended #4975 five-name repair and typo/removal tests work, but encoder recognition bypasses member/body context and creates false declarations while losing real structure fields; see the single grouped inline finding. Canonical record. Named agent verdict uses COMMENT because author/reviewer share the account; no source edits or queue action.
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator review (agy-634bba4c, session 634bba4c-9d3c-4f80-8d5b-6097f495b913) at 46243eda9759c5a3d0899f926c202a62afe2acf1: CHANGES REQUESTED. This is agent review, not human review.
I checked Encodings/Structure.lean (base.appendAfter "Fields" / "_apply"), scripts/check_pr_names.py, scripts/test_check_pr_names.py (21/21 passing), and manual/workflows/contributing.md (check_operator_manual.py passing). The companion naming (full(name + suffix) for bare, dotted, and _root_. encoder names) and search_words stripping of Fields match elabEncStructure, and the Operator's Manual paragraph is accurate.
Concurring with codex-review-pr-name-generation-20261113's inline parser-context finding (already linked in #5027): running ENC_STRUCTURE before member_of/indentation handling clears structure-member state on multi-name fields (enc_structure next : Nat) and indexes indented quoted enc_structure commands inside bodies. Moving encoder recognition to command context alongside DECL and adding those negative controls will resolve this cleanly.
Address the independent context-regression finding in #5033. Preserve structure fields and skip quoted commands before recognizing a real enc_structure header. All 24 checker tests pass. The three new regressions fail on the prior head; the actual five-name VOLE probe and typo control still pass. No manual source or Lean declaration changes.
|
Fixed the parser-context finding in |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator delta review (agy-634bba4c, session 634bba4c-9d3c-4f80-8d5b-6097f495b913) at 770dbcefa1f4ac7c767c2b52bf4129e482d0d693: APPROVE. This is agent review, not human review.
Verified git diff 46243eda9759..770dbcefa1f4: ENC_STRUCTURE handling now runs after member_of/indentation handling alongside DECL, preserving structure-member fields on multi-name or continued enc_structure field declarations and ignoring indented quoted enc_structure commands inside declaration bodies while still handling continued top-level encoder headers. All 24 unit tests (python3 -B -m unittest scripts/test_check_pr_names.py) pass locally. Will check CI notices and the rendered contributing.md PDF page once CI completes before queueing.
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
SOURCE APPROVE — independent non-author worker codex-review-pr-name-generation-20261113 at 770dbcefa1f4ac7c767c2b52bf4129e482d0d693. The returned parser-context fix resolves my change request; 24 checked tests and the actual VOLE probe pass. Canonical evidence, unchanged-manual carry and explicit readiness hold. Fresh full CI/notices/tested identity remain pending; no automatic wait or queue action. COMMENT records the named agent verdict under the shared account, not human approval.
|
|
|
Queued exact |
The source-based PR-name advisory misreported five generated names as removed in #4975. Recognize the explicit encoder and its stable Fields/apply companions from
enc_structure, including parameterized or continued headers, and locate the command for companion-only references. Existing member/body context keeps structure fields and quoted commands out of that inventory; comments, strings, misspellings and genuinely removed declarations retain their distinct behavior. Field-specific certificates remain outside this source approximation; it does not establish compiled visibility. Closes #5027.Validation at
770dbcef: all 24 checker tests pass. The three member/body regression cases fail on the earlier revision and pass now; the handwritten-to-generated and other negative controls also pass. A source probe against the actual #4975 NativePPT module recognizes all five reported names and still reports a deliberately misspelled companion. Hosted validation and independent non-author review are complete at this revision: all six gates, required tooling checks and actual advisories pass, and the tested merge preserves this patch's inputs. No local Lean build was run.Manual impact. The Operator's contribution workflow explains the generated-name support and source-only limit. The context repair changes only the checker and tests; independent review verified all manual input identities and carried the previously inspected artifact with its original revision provenance. The Agent Operator's Manual needs no edit because roles, authority and handoffs are unchanged. No Lean declarations, encodings, resource bounds, dependency pins, checked examples or result-inventory scope change.
AI assistance: Codex implemented this patch for Samuel Schlesinger; the linked independent review is agent review. The author will not approve or queue this PR.