Remove highlights and advanced filters for Feb release - #98
Merged
Conversation
AndrewCheung360
approved these changes
Feb 3, 2026
AndrewCheung360
left a comment
AndrewCheung360
left a comment
Member
There was a problem hiding this comment.
Nit: I think it would be better to hide these behind some sort of boolean feature flag instead of commenting out code.
Contributor
Author
|
will def implement feature flags next time but leaving them out for now since we're in a time crunch for releasing this 🙏 |
… feb-release-modifications
…ev/score-android into feb-release-modifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Highlights UI and Advanced filters UI are currently in main, although they're not networked. Since we're releasing bug fixes ASAP, I commented out UI access points to highlights and advanced filters temporarily (saved copy of current main to branch
jan-main-copyjust in case). All code for highlights and advanced filters still exists in this branch though.Changes Made