Repository navigation
fix(audio): include <spa/pod/iter.h> for spa_pod_find_prop() - #18
Merged
Merged
Conversation
audio_object.cpp calls spa_pod_find_prop() but only includes
<spa/pod/parser.h>, so the declaration is missing and newer
pipewire headers no longer pull iter.h in transitively.
Building with GCC 16.2.0 and pipewire 1.4.x fails with:
clients/audio/audio_object.cpp: In function 'const spa_pod_prop* cutefish::audio::AudioObject::getProp(const char*)':
clients/audio/audio_object.cpp:34:34: error: 'spa_pod_find_prop' was not declared in this scope
34 | const spa_pod_prop* prop = spa_pod_find_prop(object, nullptr, key);
| ^~~~~~~~~~~
clients/audio/audio_object.cpp:34:34: note: suggested alternative: 'spa_pod_for_each_prop'
Include <spa/pod/iter.h> explicitly to get the declaration.
Member
|
Thanks for the fix! I reproduced the error by building against the pipewire 1.6.0 spa headers, and with this change
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clients/audio/audio_object.cppcallsspa_pod_find_prop()but only includes<spa/pod/parser.h>. Newer pipewire headers no longer pulliter.hin transitively, so the declaration is missing.Building with GCC 16.2.0 and pipewire 1.4.x fails with:
Including
<spa/pod/iter.h>explicitly fixes it.