Update @d-zero/* packages and adopt using for Lanes/raceWithTimeout - #308
Merged
Conversation
Bump dealer to 1.11.0, shared to 0.23.0, page-cluster to 0.6.0, beholder to 4.2.3, fs to 0.2.7, readtext to 1.2.1, roar to 2.2.1, google-auth to 0.7.6, and google-sheets to 0.10.0 across all consuming workspaces. Also bump crawler's own puppeteer pin from 25.3.0 to 25.5.0 to match what beholder@4.2.3 now requires, avoiding a duplicate puppeteer-core install with structurally incompatible Page types.
Replace the hand-rolled Promise.race + setTimeout + clearTimeout pattern in fetchDestination, closeBrowserSafely, and ArchiveAccessor#runClose with @d-zero/shared's raceWithTimeout, now that dealer/shared ship it. Update the ARCHITECTURE.md invariant on Promise.race timer cleanup to point at raceWithTimeout as the default instead of the manual pattern.
Drop the local mkdtempDisposable helper in externalSortUrls now that @d-zero/shared ships the same disposable-temp-dir pattern, and adapt call sites to its single-prefix signature.
Replace the manual try/finally lanes?.close() around report generation with `using`, now that dealer's Lanes implements Symbol.dispose. The using declaration is scoped to a nested block ending before the post-report console output, matching the prior close-before-write ordering. Update the spec's close() spy to Symbol.dispose to match.
Replace the manual try/finally lanes?.close() with `using`, now that dealer's Lanes implements Symbol.dispose. The using declaration is scoped to a nested block ending before nitpicker.write(), matching the prior close-before-write ordering. Update the spec's Lanes mock to implement Symbol.dispose instead of a dead close() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@d-zero/*runtime dependencies (dealer, shared, page-cluster, beholder, fs, readtext, roar, google-auth, google-sheets) to their latest fixed versions, released today with Explicit Resource Management (using/Symbol.dispose) support.puppeteerpin (25.3.0 → 25.5.0) to match what@d-zero/beholder@4.2.3now requires, avoiding a duplicatepuppeteer-coreinstall with structurally incompatiblePagetypes.usingfor the twoLaneslifecycles (cli'sanalyzecommand,report-google-sheets) now that@d-zero/dealer@1.11.0implementsSymbol.disposeonLanes, replacing the manualtry/finally+lanes?.close()pattern.Promise.race+setTimeout+clearTimeouttimeout-race pattern infetchDestination,closeBrowserSafely, andArchiveAccessor#runClosewith@d-zero/shared's newraceWithTimeouthelper.query's localmkdtempDisposableimplementation in favor of@d-zero/shared's newmkdtempDisposablehelper.Promise.racetimer cleanup to point atraceWithTimeoutas the default.Test plan
yarn build(withNX_WORKSPACE_ROOT_PATHset for the worktree)yarn lintyarn test(634 test files, 4570 tests passed, 4 pre-existing skips)