feat(auth): give the public pages the post page's signup banner - #6727
Open
tsahimatsliah wants to merge 6 commits into
Open
tsahimatsliah wants to merge 6 commits into
tsahimatsliah wants to merge 6 commits into
Conversation
The pinned card lost its experiment against the post page's banner, so the public pages (explore, tags, tag pages, squads, sources, source pages, leaderboard, best-of, worlds, watercooler, profiles) drop the inline cover strip and get that banner instead: the full-width bar pinned to the bottom of the window for anonymous laptop visitors, with the same personalized referrer, social and geo variants the post page renders. PublicPageSignupBanner already mounted it behind public_signup_banner on five of these pages; it now mounts everywhere unconditionally, the flag goes, and it carries the same clearance the post page adds so the end of each page stays reachable above the bar. On the explore hub it also takes the sponsor dock's bottom slot, so the dock is disabled while the banner shows. The strip, its target id and the cover strip's button pair are removed; the extension's new tab still uses HijackingCoverStrip. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- PostAuthBanner loads lazily from PublicPageSignupBanner, as the post page does, so the auth form tree stays out of the feed layout's chunk for members and the extension. - The banner logs one impression per visit under its own target id, so the surface stays measurable now that the strip's id is gone. - Source-file imports instead of the hooks barrels. - The feed layout's new lines move above the sponsor strip's comment, which describes the hook call under it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tsahimatsliah
marked this pull request as ready for review
September 25, 2026 12:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pinned card lost its experiment against the post page's signup banner, so the public pages get that banner instead of the inline cover strip.
PostAuthBanner), including its personalized referrer, social and geo variants. The inline "Unlock the full daily.dev experience" strip is gone.PublicPageSignupBanneralready rendered it behindpublic_signup_banneron five of these pages. It now mounts on all of them unconditionally, the flag is removed, and it carries an 18rem clearance spacer (the same the post page adds) so the end of each page stays reachable above the bar.public page signup bannertarget id so the surface stays measurable now that the strip's id is gone.ExploreSignupStripand its spec, theexplore striptarget id, the cover strip's sign up / log in button pair and placeholder. The extension's new tab still usesHijackingCoverStrip.Test plan
🤖 Generated with Claude Code
Preview domain
https://claude-public-pages-post-banner.preview.app.daily.dev