feat(snapshot): credit the post title on text snapshots - #6730
Open
tomeredlich wants to merge 2 commits into
Open
tomeredlich wants to merge 2 commits into
tomeredlich wants to merge 2 commits into
Conversation
TLDR, paragraph, text-selection and Happening now snapshots only credited the source, so a shared image never said which article the passage came from. The title now sits under the divider, above the source, at a smaller size than the copy so the passage stays the subject. Happening now fetches the post (or shared post) title and falls back to the highlight headline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
idoshamun
approved these changes
Sep 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text snapshots (TLDR, paragraph, text selection, Happening now) credited only the source, so a shared image never said which article the passage came from. The post title now sits under the divider, above the source, smaller than the passage so the copy stays the subject.
HighlightTextSnapshotCardtakes an optionaltitle, rendered bySnapshotCreditunder the rule (cut at a word after 140 chars).TextSnapshotButtonandSelectionSnapshotBarpasspost.title; covers post page, modal, focus card, shared posts, freeform, collections and briefs.titlefor the post and shared post; falls back to the highlight headline.Test plan
TextSnapshotButtonspec asserts the title lands on the staged cardpnpm --filter webapp testpass🤖 Generated with Claude Code
Preview domain
https://feat-snapshot-post-title.preview.app.daily.dev