Repository navigation
Fix uninitialized pwm_ variable in led.cpp - #721
Merged
stephenhensley merged 2 commits intoOct 14, 2026
Merged
Conversation
pwm_ could have an illegal value in which case the LEDs would not work.
Collaborator
|
Looks good to me! Thanks for the fix! The style fix should be simple to fix. The build CI failure is not your fault, and I'll be resolving that today. |
Collaborator
|
LGTM! Thanks for the contribution!! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pwm_ was not initialized and would cause LEDs to not work in bkshepherd project when compiled with a more recent compiler than 2020 (gcc 10).
Verified with this branch and the bkshepherd project.