Number density - #871
Merged
Merged
Number density#871
Conversation
…k for two-kernel scheme
…stead of the old rhoh function
… write rho to dumps if apr=yes
|
Important Review skippedToo many files! This PR contains 212 files, which is 112 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (212)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…h apr + fix issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implement h-depends-on-number density as described in Price (2012), needed for APR. Without APR the h-n formulation is identical to the usual h-rho formulation.
This P-R also implements preliminary work to allow the number density kernel to differ from the density kernel. Right now these kernels are wired to be the same but the infrastructure exists to allow them to change.
The main structural change in the code is that we now explicitly store the density as an array, rho(:), which avoids the need to use the rhoh() function all over the place. This neatens the code in a number of places.
To save disk space, we still only write h to the dump, and reconstruct rho-from-h on reading the dump, in the case where no apr is used, and when the kernel for number density is the same as the kernel for mass density.
Components modified:
Type of change:
Testing:
Conservation properties tested with APR (thanks to Chunliang Mu and Rebecca Nealon) and in test suite.
Did you run the bots? no
Did you update relevant documentation in the docs directory? yes
Did you add comments such that the purpose of the code is understandable? yes
Is there a unit test that could be added for this feature/bug? yes
If so, please describe what a unit test might check:
some unit tests already added
Related issues: #