Repository navigation
Toolbar: Undo and Redo keep their names in the » menu - #310
Merged
Merged
Conversation
On GNUstep the icon-only toolbar items have empty labels, and the » menu titles an overflowed item from its label unless it has a menu form of its own. Since #303 Undo and Redo are the first items to overflow, so they showed there as blank rows. Give the icon items a titled menu form, as the labelled items (Save, Copy) already have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
danjboyd
added a commit
that referenced
this pull request
Oct 21, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW
danjboyd
marked this pull request as ready for review
October 21, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Adwaita (and WinUITheme, by the same code path), when the window is narrow enough for Undo and Redo to go into », they showed there as two blank rows. Clicking the blank row still undid. Found in the Linux 0.3.2-rc1 round.
Cause: on GNUstep,
-baselineToolbarItemWithIdentifier:gives icon-only items an empty label, and the » menu titles an overflowed item from its label unless it has amenuFormRepresentation. The labelled items (Save, Copy) already had one. Before #303 Undo and Redo never overflowed first, so it didn't show.Fix: icon items get a titled menu form with the item's action and the app delegate as target, so
-validateMenuItem:enables Undo and Redo as in the Edit menu.Tests:
TitleBarToolbarProbeTests/testIconItemsKeepTheirNamesInTheOverflowMenufails on main (nil menu form) and passes here. Full suite: 63 suites pass under the default theme and under Adwaita (3 skips each, as on main).For 0.3.2-rc2.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V8rjzo3Qk8M7WcT9RYfYRW